From 63a77416b7aa2b5477bd65aa37fc38269f462dcc Mon Sep 17 00:00:00 2001 From: pq Date: Fri, 4 Jun 2021 14:19:08 +0000 Subject: [PATCH] enable `depend_on_referenced_packages` this is under consideration for core lint inclusion: https://github.com/dart-lang/lints/issues/42 (also undoubtably nice to get the early warning.) Change-Id: I3ea204444f48d3b4bde3ff65b4ce85a2cf2a7b11 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202301 Commit-Queue: Phil Quitslund Reviewed-by: Konstantin Shcheglov Reviewed-by: Brian Wilkerson --- pkg/analysis_server/analysis_options.yaml | 1 + pkg/analysis_server_client/analysis_options.yaml | 1 + pkg/analyzer/analysis_options.yaml | 1 + pkg/analyzer_cli/analysis_options.yaml | 1 + pkg/analyzer_plugin/analysis_options.yaml | 1 + pkg/dartdev/analysis_options.yaml | 1 + 6 files changed, 6 insertions(+) diff --git a/pkg/analysis_server/analysis_options.yaml b/pkg/analysis_server/analysis_options.yaml index 06e8506ee1b..90f1d2258d8 100644 --- a/pkg/analysis_server/analysis_options.yaml +++ b/pkg/analysis_server/analysis_options.yaml @@ -17,6 +17,7 @@ linter: rules: - await_only_futures - avoid_single_cascade_in_expression_statements + - depend_on_referenced_packages - empty_statements - iterable_contains_unrelated_type - list_remove_unrelated_type diff --git a/pkg/analysis_server_client/analysis_options.yaml b/pkg/analysis_server_client/analysis_options.yaml index fd37fb4dfd7..e4fce7efa23 100644 --- a/pkg/analysis_server_client/analysis_options.yaml +++ b/pkg/analysis_server_client/analysis_options.yaml @@ -5,6 +5,7 @@ analyzer: linter: rules: - await_only_futures + - depend_on_referenced_packages - empty_statements - unnecessary_brace_in_string_interps # diff --git a/pkg/analyzer/analysis_options.yaml b/pkg/analyzer/analysis_options.yaml index 9996e7fe0ba..1d8a622649e 100644 --- a/pkg/analyzer/analysis_options.yaml +++ b/pkg/analyzer/analysis_options.yaml @@ -30,6 +30,7 @@ linter: - avoid_dynamic_calls - avoid_unused_constructor_parameters - await_only_futures + - depend_on_referenced_packages - empty_statements - iterable_contains_unrelated_type - list_remove_unrelated_type diff --git a/pkg/analyzer_cli/analysis_options.yaml b/pkg/analyzer_cli/analysis_options.yaml index e69ac71d34e..069c2d2b62f 100644 --- a/pkg/analyzer_cli/analysis_options.yaml +++ b/pkg/analyzer_cli/analysis_options.yaml @@ -11,6 +11,7 @@ analyzer: linter: rules: avoid_unused_constructor_parameters: true + depend_on_referenced_packages: true directives_ordering: true # We import heavily from package:analyzer/src. diff --git a/pkg/analyzer_plugin/analysis_options.yaml b/pkg/analyzer_plugin/analysis_options.yaml index ac616cbec48..c183e268740 100644 --- a/pkg/analyzer_plugin/analysis_options.yaml +++ b/pkg/analyzer_plugin/analysis_options.yaml @@ -4,6 +4,7 @@ analyzer: linter: rules: - await_only_futures + - depend_on_referenced_packages - empty_statements - unnecessary_brace_in_string_interps # diff --git a/pkg/dartdev/analysis_options.yaml b/pkg/dartdev/analysis_options.yaml index 51689886bfe..b5b773671db 100644 --- a/pkg/dartdev/analysis_options.yaml +++ b/pkg/dartdev/analysis_options.yaml @@ -13,6 +13,7 @@ analyzer: linter: rules: - always_declare_return_types + - depend_on_referenced_packages - directives_ordering - overridden_fields - prefer_single_quotes