dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add embedder/vm layer checks to presubmits.

Browse Source 
Change-Id: Idcfe4692ac0c047ed9a0fb817a17513ff964a2eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119080
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Ryan Macnak
2019-09-30 16:28:07 +00:00
committed by commit-bot@chromium.org
parent 328addd2cf
commit 623fd5c8cd
4 changed files with 91 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PRESUBMIT.py
+13 -6
View File
@@ -216,18 +216,25 @@ def _CheckLayering(input_api, output_api):
return []
local_root = input_api.change.RepositoryRoot()
layering_check = imp.load_source(
'layering_check',
os.path.join(local_root, 'runtime', 'tools', 'layering_check.py'))
errors = layering_check.DoCheck(local_root)
compiler_layering_check = imp.load_source(
'compiler_layering_check',
os.path.join(local_root, 'runtime', 'tools',
'compiler_layering_check.py'))
errors = compiler_layering_check.DoCheck(local_root)
embedder_layering_check = imp.load_source(
'embedder_layering_check',
os.path.join(local_root, 'runtime', 'tools',
'embedder_layering_check.py'))
errors += embedder_layering_check.DoCheck(local_root)
if errors:
return [
output_api.PresubmitError(
'Layering check violation for C++ sources.',
long_text='\n'.join(errors))
]
else:
return []
return []
def _CheckClangTidy(input_api, output_api):
"""Run clang-tidy on VM changes."""