From 61b15fede82369618deaa226ce759ee68a23c29a Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Mon, 16 Apr 2018 21:13:09 +0000 Subject: [PATCH] [build] Remove unnecessary inputs from uses of application_snapshot. These dependencies are tracked via a depfile generated along with the snapshot. Change-Id: I4245a982212a5aff28aea8456d0219808df54af0 Reviewed-on: https://dart-review.googlesource.com/51245 Reviewed-by: Zach Anderson Commit-Queue: Ryan Macnak --- utils/dartanalyzer/BUILD.gn | 14 -------------- utils/dartdevc/BUILD.gn | 16 ++-------------- utils/dartdoc/BUILD.gn | 4 ---- utils/dartfmt/BUILD.gn | 5 ----- utils/pub/BUILD.gn | 8 -------- 5 files changed, 2 insertions(+), 45 deletions(-) diff --git a/utils/dartanalyzer/BUILD.gn b/utils/dartanalyzer/BUILD.gn index 67415d5c66b..961951224da 100644 --- a/utils/dartanalyzer/BUILD.gn +++ b/utils/dartanalyzer/BUILD.gn @@ -27,25 +27,11 @@ application_snapshot("generate_dartanalyzer_snapshot") { rebase_path("../../tests/language/first_test.dart"), ] name = "dartanalyzer" - cli_files = exec_script("../../tools/list_dart_files.py", - [ - "absolute", - rebase_path("../../pkg/analyzer_cli"), - ], - "list lines") - inputs = cli_files + analyzer_files } aot_assembly("dartanalyzer_aot_assembly") { main_dart = "../../pkg/analyzer_cli/bin/analyzer.dart" name = "dartanalyzer" - cli_files = exec_script("../../tools/list_dart_files.py", - [ - "absolute", - rebase_path("../../pkg/analyzer_cli"), - ], - "list lines") - inputs = cli_files + analyzer_files } # This target is for Goma. It should not be used in the SDK. diff --git a/utils/dartdevc/BUILD.gn b/utils/dartdevc/BUILD.gn index 9e75067e74a..e9a61602598 100644 --- a/utils/dartdevc/BUILD.gn +++ b/utils/dartdevc/BUILD.gn @@ -30,13 +30,7 @@ application_snapshot("dartdevc") { ":dartdevc_sdk", ] - inputs = exec_script("../../tools/list_dart_files.py", - [ - "absolute", - rebase_path("../../pkg/dev_compiler/bin"), - ], - "list lines") - inputs += [ sdk_summary ] + inputs = [ sdk_summary ] } application_snapshot("dartdevk") { @@ -55,13 +49,7 @@ application_snapshot("dartdevk") { ":dartdevc_sdk_kernel_summary", ] - inputs = exec_script("../../tools/list_dart_files.py", - [ - "absolute", - rebase_path("../../pkg/dev_compiler/bin"), - ], - "list lines") - inputs += [ sdk_dill ] + inputs = [ sdk_dill ] } sdk_lib_files = exec_script("../../tools/list_dart_files.py", diff --git a/utils/dartdoc/BUILD.gn b/utils/dartdoc/BUILD.gn index ac302a821bc..0ba4fe2b644 100644 --- a/utils/dartdoc/BUILD.gn +++ b/utils/dartdoc/BUILD.gn @@ -7,8 +7,4 @@ import("../application_snapshot.gni") application_snapshot("dartdoc") { main_dart = "../../third_party/pkg/dartdoc/bin/dartdoc.dart" training_args = [ "--help" ] - inputs = exec_script("../../tools/list_dart_files.py", - [ "absolute", - rebase_path("../../third_party/pkg/dartdoc") ], - "list lines") } diff --git a/utils/dartfmt/BUILD.gn b/utils/dartfmt/BUILD.gn index 7c688a318f6..566475fcb9f 100644 --- a/utils/dartfmt/BUILD.gn +++ b/utils/dartfmt/BUILD.gn @@ -7,9 +7,4 @@ import("../application_snapshot.gni") application_snapshot("dartfmt") { main_dart = "../../third_party/pkg_tested/dart_style/bin/format.dart" training_args = [ "--help" ] - inputs = - exec_script("../../tools/list_dart_files.py", - [ "absolute", - rebase_path("../../third_party/pkg_tested/dart_style") ], - "list lines") } diff --git a/utils/pub/BUILD.gn b/utils/pub/BUILD.gn index 33cea340185..b2f724c1a74 100644 --- a/utils/pub/BUILD.gn +++ b/utils/pub/BUILD.gn @@ -7,12 +7,4 @@ import("../application_snapshot.gni") application_snapshot("pub") { main_dart = "../../third_party/pkg/pub/bin/pub.dart" training_args = [ "--help" ] - deps = [ - "../compiler:dart2js_files_stamp", - ] - dart2js_gen_dir = - get_label_info("../compiler:dart2js_files_stamp", "target_gen_dir") - inputs = [ - "$dart2js_gen_dir/dart2js_files.stamp", - ] }