From 6152811edaf02f94cc9fd987d539d1aa6938a26b Mon Sep 17 00:00:00 2001 From: DEPS Autoroller Date: Mon, 22 Sep 2025 10:15:35 -0700 Subject: [PATCH] Roll ninja from 2@1.11.1.chromium.6 to 3@1.13.1.chromium.4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/ninja-dart-sdk Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ninja: https://bugs.chromium.org/p/chromium/issues/list To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try Change-Id: I94379b6282696480ce450e9fb013e1b5f04be103 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450774 Reviewed-by: Ryan Macnak --- DEPS | 2 +- tools/list_dart_files_as_depfile.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/DEPS b/DEPS index e814982a7fd..c350c3d4c56 100644 --- a/DEPS +++ b/DEPS @@ -88,7 +88,7 @@ vars = { "download_fuchsia_deps": False, # Ninja, runs the build based on files generated by GN. - "ninja_tag": "version:2@1.11.1.chromium.7", + "ninja_tag": "version:3@1.13.1.chromium.4", # Scripts that make 'git cl format' work. "clang_format_scripts_rev": "bb994c6f067340c1135eb43eed84f4b33cfa7397", diff --git a/tools/list_dart_files_as_depfile.py b/tools/list_dart_files_as_depfile.py index 84eddeec8c6..9c58d7aed2d 100644 --- a/tools/list_dart_files_as_depfile.py +++ b/tools/list_dart_files_as_depfile.py @@ -48,9 +48,8 @@ def main(argv): '.dart') and not filename.endswith('_test.dart'): fullname = os.path.join(directory, root, filename) fullname = fullname.replace(os.sep, '/') - out.write(" \"") - out.write(fullname) - out.write("\"") + out.write(" ") + out.write(fullname.replace(" ", r"\ ")) out.write("\n") out.close()