From 48cf6c5ebd7dbf6da159fec4db061fd2bdefff6f Mon Sep 17 00:00:00 2001 From: "whesse@google.com" Date: Tue, 13 Aug 2013 14:11:33 +0000 Subject: [PATCH] Fix some analyzer warnings in dart:io. BUG= R=sgjesse@google.com Review URL: https://codereview.chromium.org//22893005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26051 260f80e4-7a28-3924-810f-c04153c831b5 --- sdk/lib/io/directory_impl.dart | 4 ++-- sdk/lib/io/file_impl.dart | 2 +- sdk/lib/io/http.dart | 2 ++ sdk/lib/io/websocket_impl.dart | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/sdk/lib/io/directory_impl.dart b/sdk/lib/io/directory_impl.dart index 17d67bee76c..e27b6103f64 100644 --- a/sdk/lib/io/directory_impl.dart +++ b/sdk/lib/io/directory_impl.dart @@ -98,7 +98,7 @@ class _Directory implements Directory { } Future createRecursively() { - var path = new Path(path); + var path = new Path(this.path); var dirsToCreate = []; var terminator = path.isAbsolute ? '/' : ''; while (path.toString() != terminator) { @@ -139,7 +139,7 @@ class _Directory implements Directory { } void createRecursivelySync() { - var path = new Path(path); + var path = new Path(this.path); var dirsToCreate = []; var terminator = path.isAbsolute ? '/' : ''; while (path.toString() != terminator) { diff --git a/sdk/lib/io/file_impl.dart b/sdk/lib/io/file_impl.dart index b6a47c7969d..cf9a7ef3617 100644 --- a/sdk/lib/io/file_impl.dart +++ b/sdk/lib/io/file_impl.dart @@ -346,7 +346,7 @@ class _File implements File { } Directory get directory { - Path path = new Path(path).directoryPath; + Path path = new Path(this.path).directoryPath; return new Directory.fromPath(path); } diff --git a/sdk/lib/io/http.dart b/sdk/lib/io/http.dart index 4b490c215e3..90b36a12647 100644 --- a/sdk/lib/io/http.dart +++ b/sdk/lib/io/http.dart @@ -1489,4 +1489,6 @@ class RedirectException implements HttpException { List this.redirects); String toString() => "RedirectException: $message"; + + Uri get uri => redirects.last.location; } diff --git a/sdk/lib/io/websocket_impl.dart b/sdk/lib/io/websocket_impl.dart index 140bd3bd3b3..aec29197075 100644 --- a/sdk/lib/io/websocket_impl.dart +++ b/sdk/lib/io/websocket_impl.dart @@ -826,7 +826,7 @@ class _WebSocketImpl extends Stream implements WebSocket { cancelOnError: cancelOnError); } - Duration get pingnterval => _pingInterval; + Duration get pingInterval => _pingInterval; void set pingInterval(Duration interval) { if (_writeClosed) return;