From 47f537cdf705115b9ad4e6068336acac40d8597c Mon Sep 17 00:00:00 2001 From: William Hesse Date: Fri, 7 Jan 2022 14:39:20 +0000 Subject: [PATCH] [infra] Remove duplicate flutter analyze snippets step from script The snippets analyze step in [flutter]/dev/bots/analyze.dart now uses our built SDK when analyzing the code snippets. The explicit duplicate command to analyze the snippets with our SDK can now be removed. The temp directory created in the script is not in the builder cache on swarming, so it is automatically deleted when the builder finishes. So we remove the cleanup step, which was trapping signals. That trap seems to have been responsible for these failures and exit code confusion. Bug: https://github.com/dart-lang/sdk/issues/47881 Change-Id: I49406954af54a0fba1ceec230c3551f8ad14e8e9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226685 Reviewed-by: Paul Berry --- tools/bots/flutter/analyze_flutter_flutter.sh | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tools/bots/flutter/analyze_flutter_flutter.sh b/tools/bots/flutter/analyze_flutter_flutter.sh index fbfb2642ed4..6fa042523ec 100755 --- a/tools/bots/flutter/analyze_flutter_flutter.sh +++ b/tools/bots/flutter/analyze_flutter_flutter.sh @@ -11,10 +11,6 @@ checkout=$(pwd) dart=$checkout/out/ReleaseX64/dart-sdk/bin/dart sdk=$checkout/out/ReleaseX64/dart-sdk tmpdir=$(mktemp -d) -cleanup() { - rm -rf "$tmpdir" -} -trap cleanup EXIT HUP INT QUIT TERM PIPE cd "$tmpdir" git clone --single-branch -vv \ @@ -37,6 +33,3 @@ $dart --enable-asserts dev/bots/analyze.dart --dart-sdk $sdk # Test flutter's use of data-driven fixes. $dart fix packages/flutter/test_fixes --compare-to-golden - -# Analyze the sample code in dartdoc snippets. -PUB_CACHE=$checkout/.pub_cache $dart dev/bots/analyze_sample_code.dart