From 47ed51fe3f6f58d6f72734e798c3457e03771329 Mon Sep 17 00:00:00 2001 From: Vyacheslav Egorov Date: Thu, 19 Oct 2017 07:13:06 +0000 Subject: [PATCH] [VM] Relax assertions in NativeArguments allowing native generic functions NativeArguments don't allow you to access type arguments, but calling conventions are setup in such a way that nothing else needs to be changed. This is needed because we changed List makeListFixedLength(List growableList) native "Internal_makeListFixedLength"; to List makeListFixedLength(List growableList) native "Internal_makeListFixedLength"; Bug: Change-Id: I2f8755f25c488a422a60f3efce2541de7cbeae0e Reviewed-on: https://dart-review.googlesource.com/15080 Reviewed-by: Vyacheslav Egorov --- runtime/vm/native_arguments.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/runtime/vm/native_arguments.h b/runtime/vm/native_arguments.h index 43aa0967b63..a083201f01d 100644 --- a/runtime/vm/native_arguments.h +++ b/runtime/vm/native_arguments.h @@ -151,7 +151,6 @@ class NativeArguments { static intptr_t ParameterCountForResolution(const Function& function) { ASSERT(function.is_native()); - ASSERT(!function.IsGeneric()); // Not supported. ASSERT(!function.IsGenerativeConstructor()); // Not supported. intptr_t count = function.NumParameters(); if (function.is_static() && function.IsClosureFunction()) { @@ -166,7 +165,6 @@ class NativeArguments { static int ComputeArgcTag(const Function& function) { ASSERT(function.is_native()); - ASSERT(!function.IsGeneric()); // Not supported. ASSERT(!function.IsGenerativeConstructor()); // Not supported. int tag = ArgcBits::encode(function.NumParameters()); int function_bits = 0;