From 475efb170836736f2a888d9e8ea17088a1333f5f Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Fri, 31 Oct 2025 12:04:10 -0700 Subject: [PATCH] Revert "[dart2wasm] Also use --traps-never-happen in deferred loading mode" This reverts commit 6bcbc740e5d08fe82ef4de869c5f9c4f542d3c6e. Reason for revert: Broke pkg/dart2wasm/test/ir_test Original change's description: > [dart2wasm] Also use --traps-never-happen in deferred loading mode > > The dar2wasm compiler - when used in -O2 sound mode - should guarantee > that no wasm traps happen. So we should be able to use > `--traps-never-happen` in deferred loading mode just like in normal > mode. > > This saves around 1.2% in ACX Gallery > > Change-Id: I3d214b636b0bc2e8b18c2ef8c4bf0c86b19c23c8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458720 > Commit-Queue: Martin Kustermann > Reviewed-by: Nate Biggs Change-Id: If51986574a7dc587b64b258278d763d51b3d28df Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458900 Commit-Queue: Paul Berry Reviewed-by: Nicholas Shahan Bot-Commit: Rubber Stamper Auto-Submit: Paul Berry --- pkg/dartdev/lib/src/commands/compile.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/dartdev/lib/src/commands/compile.dart b/pkg/dartdev/lib/src/commands/compile.dart index 4b32c907b64..2a6adabd99b 100644 --- a/pkg/dartdev/lib/src/commands/compile.dart +++ b/pkg/dartdev/lib/src/commands/compile.dart @@ -765,7 +765,6 @@ class CompileWasmCommand extends CompileSubcommandCommand { --no-inline=** - --traps-never-happen -Os '''); // end of binaryenFlagsDeferredLoading