From 43dafefa15cd2dab71ac2a3e792e0f1c77d55feb Mon Sep 17 00:00:00 2001 From: Joshua Litt Date: Tue, 10 Mar 2020 18:30:20 +0000 Subject: [PATCH] [dart2js] Fix bug with constant ordering and nnbd. Change-Id: I8fd1a0b50f793dc3dec4b3a9a1fd127fb6ebb288 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138908 Reviewed-by: Mayank Patke Commit-Queue: Joshua Litt --- pkg/compiler/lib/src/js_emitter/constant_ordering.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/compiler/lib/src/js_emitter/constant_ordering.dart b/pkg/compiler/lib/src/js_emitter/constant_ordering.dart index 2b044b34894..48281f35c4f 100644 --- a/pkg/compiler/lib/src/js_emitter/constant_ordering.dart +++ b/pkg/compiler/lib/src/js_emitter/constant_ordering.dart @@ -245,17 +245,17 @@ class _DartTypeOrdering extends DartTypeVisitor { @override int visitLegacyType(covariant LegacyType type, covariant LegacyType other) => - visit(type.baseType, other.baseType); + compare(type.baseType, other.baseType); @override int visitNullableType( covariant NullableType type, covariant NullableType other) => - visit(type.baseType, other.baseType); + compare(type.baseType, other.baseType); @override int visitFutureOrType( covariant FutureOrType type, covariant FutureOrType other) => - visit(type.typeArgument, other.typeArgument); + compare(type.typeArgument, other.typeArgument); @override int visitNeverType(covariant NeverType type, covariant NeverType other) {