From 406f493bcf0e2c3e6744fe527c34b301ed8d5e00 Mon Sep 17 00:00:00 2001 From: Paul Berry Date: Fri, 29 May 2026 12:39:54 -0700 Subject: [PATCH] Sort linter rules in developer experience analysis_options.yaml files. https://dart-review.googlesource.com/c/sdk/+/505046 was created by an automated script that didn't respect the ordering of lint entries in `analysis_options.yaml` files. We usually try to keep them sorted, so this CL re-sorts them. Change-Id: I1a7d007af34b6db2f8e4f02b8cc71d2c6a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507140 Reviewed-by: Brian Wilkerson --- pkg/analysis_server/analysis_options.yaml | 4 ++-- pkg/analysis_server_client/analysis_options.yaml | 4 ++-- pkg/linter/analysis_options.yaml | 6 +++--- pkg/server_plugin/analysis_options.yaml | 4 ++-- pkg/telemetry/analysis_options.yaml | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/pkg/analysis_server/analysis_options.yaml b/pkg/analysis_server/analysis_options.yaml index 87e88571ef3..85e33320ef0 100644 --- a/pkg/analysis_server/analysis_options.yaml +++ b/pkg/analysis_server/analysis_options.yaml @@ -21,8 +21,6 @@ analyzer: linter: rules: - - unnecessary_type_name_in_constructor - - unnecessary_const_in_enum_constructor - avoid_bool_literals_in_conditional_expressions - avoid_redundant_argument_values - deprecated_member_use_from_same_package @@ -32,8 +30,10 @@ linter: - unawaited_futures - unnecessary_async - unnecessary_breaks + - unnecessary_const_in_enum_constructor - unnecessary_final - unnecessary_ignore - unnecessary_library_directive - unnecessary_parenthesis + - unnecessary_type_name_in_constructor - unreachable_from_main diff --git a/pkg/analysis_server_client/analysis_options.yaml b/pkg/analysis_server_client/analysis_options.yaml index e5b6a457be2..11e6a4ce1d4 100644 --- a/pkg/analysis_server_client/analysis_options.yaml +++ b/pkg/analysis_server_client/analysis_options.yaml @@ -12,11 +12,11 @@ analyzer: linter: rules: - - unnecessary_type_name_in_constructor - - unnecessary_const_in_enum_constructor - always_declare_return_types - avoid_bool_literals_in_conditional_expressions - no_literal_bool_comparisons - omit_local_variable_types - prefer_single_quotes - unawaited_futures + - unnecessary_const_in_enum_constructor + - unnecessary_type_name_in_constructor diff --git a/pkg/linter/analysis_options.yaml b/pkg/linter/analysis_options.yaml index 1fa31701215..69b08b6be99 100644 --- a/pkg/linter/analysis_options.yaml +++ b/pkg/linter/analysis_options.yaml @@ -12,8 +12,6 @@ analyzer: linter: rules: - - unnecessary_type_name_in_constructor - - unnecessary_const_in_enum_constructor - always_put_required_named_parameters_first - avoid_annotating_with_dynamic - avoid_bool_literals_in_conditional_expressions @@ -37,8 +35,8 @@ linter: - join_return_with_assignment - literal_only_boolean_expressions - no_adjacent_strings_in_list - - noop_primitive_operations - no_literal_bool_comparisons + - noop_primitive_operations - only_throw_errors - parameter_assignments - prefer_asserts_in_initializer_lists @@ -55,6 +53,7 @@ linter: - unawaited_futures - unnecessary_async - unnecessary_breaks + - unnecessary_const_in_enum_constructor - unnecessary_final - unnecessary_ignore - unnecessary_lambdas @@ -62,6 +61,7 @@ linter: - unnecessary_null_checks - unnecessary_parenthesis - unnecessary_statements + - unnecessary_type_name_in_constructor - unreachable_from_main - use_late_for_private_fields_and_variables - use_setters_to_change_properties diff --git a/pkg/server_plugin/analysis_options.yaml b/pkg/server_plugin/analysis_options.yaml index 599bc023919..6707fd8c694 100644 --- a/pkg/server_plugin/analysis_options.yaml +++ b/pkg/server_plugin/analysis_options.yaml @@ -13,8 +13,6 @@ analyzer: linter: rules: - - unnecessary_type_name_in_constructor - - unnecessary_const_in_enum_constructor - always_use_package_imports - avoid_dynamic_calls - avoid_redundant_argument_values @@ -23,7 +21,9 @@ linter: - prefer_single_quotes - unawaited_futures - unnecessary_breaks + - unnecessary_const_in_enum_constructor - unnecessary_library_directive - unnecessary_parenthesis + - unnecessary_type_name_in_constructor - unreachable_from_main diff --git a/pkg/telemetry/analysis_options.yaml b/pkg/telemetry/analysis_options.yaml index 6688b1c0d1c..bd121cca9cb 100644 --- a/pkg/telemetry/analysis_options.yaml +++ b/pkg/telemetry/analysis_options.yaml @@ -6,6 +6,6 @@ analyzer: linter: rules: - - unnecessary_type_name_in_constructor - - unnecessary_const_in_enum_constructor - unawaited_futures + - unnecessary_const_in_enum_constructor + - unnecessary_type_name_in_constructor