dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Remove the notion of required fixes from dartfix and the server

Browse Source 
Change-Id: I55389e1978d11820142961b5997d2187d1e61bae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132973
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
This commit is contained in:
Brian Wilkerson
2020-01-24 01:05:41 +00:00
committed by commit-bot@chromium.org
parent 169dd530f3
commit 3d7dd5bfe0
19 changed files with 50 additions and 260 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java
+6 -7
View File
@@ -480,11 +480,11 @@ public interface AnalysisServer {
* those sources. These edits may include changes to sources outside the set of specified sources
* if a change in a specified source requires it.
*
* If includedFixes is specified, then those fixes will be applied. If includeRequiredFixes is
* specified, then "required" fixes will be applied in addition to whatever fixes are specified in
* includedFixes if any. If neither includedFixes nor includeRequiredFixes is specified, then all
* fixes will be applied. If excludedFixes is specified, then those fixes will not be applied
* regardless of whether they are "required" or specified in includedFixes.
* If includedFixes is specified, then those fixes will be applied. If includePedanticFixes is
* specified, then fixes associated with the pedantic rule set will be applied in addition to
* whatever fixes are specified in includedFixes if any. If neither includedFixes nor
* includePedanticFixes is specified, then no fixes will be applied. If excludedFixes is specified,
* then those fixes will not be applied regardless of whether they are specified in includedFixes.
*
* @param included A list of the files and directories for which edits should be suggested. If a
* request is made with a path that is invalid, e.g. is not absolute and normalized, an
@@ -496,14 +496,13 @@ public interface AnalysisServer {
* specified that does not match the name of a known fix, an error of type UNKNOWN_FIX will
* be generated.
* @param includePedanticFixes A flag indicating whether "pedantic" fixes should be applied.
* @param includeRequiredFixes A flag indicating whether "required" fixes should be applied.
* @param excludedFixes A list of names indicating which fixes should not be applied. If a name is
* specified that does not match the name of a known fix, an error of type UNKNOWN_FIX will
* be generated.
* @param port Deprecated: This field is now ignored by server.
* @param outputDir Deprecated: This field is now ignored by server.
*/
public void edit_dartfix(List<String> included, List<String> includedFixes, boolean includePedanticFixes, boolean includeRequiredFixes, List<String> excludedFixes, int port, String outputDir, DartfixConsumer consumer);
public void edit_dartfix(List<String> included, List<String> includedFixes, boolean includePedanticFixes, List<String> excludedFixes, int port, String outputDir, DartfixConsumer consumer);
/**
* {@code edit.format}