From 3b7716ab00c3514a446334cbb331707f2fc942c7 Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Thu, 26 Dec 2024 12:28:38 -0800 Subject: [PATCH] [gardening] Fix embedder_samples_test leaks, uninitialized variables. Fixes https://github.com/dart-lang/sdk/issues/59810 TEST=ci Change-Id: I8dca122538195c8aad98e0d0fb64c7ea8e0d2e1a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402421 Reviewed-by: Brian Quinlan Commit-Queue: Alexander Aprelev --- samples/embedder/run_kernel.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/samples/embedder/run_kernel.cc b/samples/embedder/run_kernel.cc index 3b6927a0910..a98d38e0630 100644 --- a/samples/embedder/run_kernel.cc +++ b/samples/embedder/run_kernel.cc @@ -73,7 +73,9 @@ std::string ReadSnapshot(std::string_view path) { char* bytes = static_cast(std::malloc(length)); source_file.read(bytes, length); - return std::string(bytes, length); + auto result = std::string(bytes, length); + std::free(bytes); + return result; } Dart_Handle ToDartStringList(const std::vector& values) { @@ -122,6 +124,7 @@ int main(int argc, char** argv) { // Start an isolate from a platform kernel. Dart_IsolateFlags isolate_flags; + Dart_IsolateFlagsInitialize(&isolate_flags); Dart_CreateIsolateGroupFromKernel( /*script_uri=*/snapshot_uri.c_str(),