From 378ab67916c45ad70e89d053747a8045d12a633b Mon Sep 17 00:00:00 2001 From: Ben Konyi Date: Mon, 12 Jul 2021 23:23:38 +0000 Subject: [PATCH] [ Benchmarks ] Output CodeSize of 0 for missing artifacts on certain platforms Change-Id: Iceee212c432524055650a2a008d3023aa84efe82 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206585 Reviewed-by: William Hesse Commit-Queue: Ben Konyi --- benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart | 9 +++++++-- benchmarks/SDKArtifactSizes/dart2/SDKArtifactSizes.dart | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart b/benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart index 1130ac6926a..ece1bcc5c14 100644 --- a/benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart +++ b/benchmarks/SDKArtifactSizes/dart/SDKArtifactSizes.dart @@ -34,8 +34,13 @@ const snapshots = [ ]; Future reportArtifactSize(String path, String name) async { - final size = await File(path).length(); - print('SDKArtifactSizes.$name(CodeSize): $size'); + try { + final size = await File(path).length(); + print('SDKArtifactSizes.$name(CodeSize): $size'); + } on FileSystemException { + // Report dummy data for artifacts that don't exist for specific platforms. + print('SDKArtifactSizes.$name(CodeSize): 0'); + } } Future main() async { diff --git a/benchmarks/SDKArtifactSizes/dart2/SDKArtifactSizes.dart b/benchmarks/SDKArtifactSizes/dart2/SDKArtifactSizes.dart index 1130ac6926a..ece1bcc5c14 100644 --- a/benchmarks/SDKArtifactSizes/dart2/SDKArtifactSizes.dart +++ b/benchmarks/SDKArtifactSizes/dart2/SDKArtifactSizes.dart @@ -34,8 +34,13 @@ const snapshots = [ ]; Future reportArtifactSize(String path, String name) async { - final size = await File(path).length(); - print('SDKArtifactSizes.$name(CodeSize): $size'); + try { + final size = await File(path).length(); + print('SDKArtifactSizes.$name(CodeSize): $size'); + } on FileSystemException { + // Report dummy data for artifacts that don't exist for specific platforms. + print('SDKArtifactSizes.$name(CodeSize): 0'); + } } Future main() async {