Add a flag to the bulk fix protocol to support testing
I think it makes more sense for the server to read the config file than for `dart fix` to read it and then pass the data to server as part of the protocol, which it would effectively need to be parsed a second time. But I don't want config files to be used outside of test mode, so I added the flag to the protocol. Let me know if you can think of a better approach. Change-Id: I1c53bc995272451247e84914f2cd6b75a837ee1e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180082 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
committed by
commit-bot@chromium.org
parent
dce8fcda1b
commit
3621c6a02f
@@ -481,8 +481,12 @@ public interface AnalysisServer {
|
||||
* file which does not exist, or which is not currently subject to analysis (e.g. because
|
||||
* it is not associated with any analysis root specified to analysis.setAnalysisRoots), an
|
||||
* error of type FILE_NOT_ANALYZED will be generated.
|
||||
* @param inTestMode A flag indicating whether the bulk fixes are being run in test mode. The only
|
||||
* difference is that in test mode the fix processor will look for a configuration file
|
||||
* that can modify the content of the data file used to compute the fixes when data-driven
|
||||
* fixes are being considered. If this field is omitted the flag defaults to false.
|
||||
*/
|
||||
public void edit_bulkFixes(List<String> included, BulkFixesConsumer consumer);
|
||||
public void edit_bulkFixes(List<String> included, boolean inTestMode, BulkFixesConsumer consumer);
|
||||
|
||||
/**
|
||||
* {@code edit.dartfix}
|
||||
|
||||
Reference in New Issue
Block a user