dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[vm, gc] Mark through new-space."

Browse Source 
This reverts commit 3fb88e4c66.

Reason for revert: b/297175670

Original change's description:
> [vm, gc] Mark through new-space.
>
>  - Initial and final marking no longer visit all of new-space, reducing the STW pause for major GC.
>  - A scavenge during concurrent marking must forward / filter objects in the marking worklist that are moved / collected, increasing the STW pause for minor GC.
>  - Unreachable intergenerational cycles and weak references are collected in the next mark-sweep instead of first requiring enough scavenges to promote the whole cycle or weak target into old-space.
>  - Artificial minor GCs are no longer needed to avoid memory leaks from back-to-back major GCs.
>  - reachabilityBarrier is now just a count of major GCs.
>
> TEST=ci
> Change-Id: I6362802cd93ba5ba9c39f116ddff82e4feb4c312
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/321304
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

Change-Id: I33075156160dc35861355d738a5776b74dce88b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/322344
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Ivan Inozemtsev
2023-08-23 13:13:28 +00:00
committed by Commit Queue
parent 6d8ef05196
commit 3176cfcd21
44 changed files with 506 additions and 875 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/compiler/stub_code_compiler_ia32.cc
+4 -3
View File
@@ -1411,14 +1411,15 @@ static void GenerateWriteBarrierStubHelper(Assembler* assembler, bool cards) {
__ j(ZERO, &skip_marking);
{
// Atomically clear kNotMarkedBit.
// Atomically clear kOldAndNotMarkedBit.
Label retry, done;
__ movl(EAX, FieldAddress(EBX, target::Object::tags_offset()));
__ Bind(&retry);
__ movl(ECX, EAX);
__ testl(ECX, Immediate(1 << target::UntaggedObject::kNotMarkedBit));
__ testl(ECX, Immediate(1 << target::UntaggedObject::kOldAndNotMarkedBit));
__ j(ZERO, &done); // Marked by another thread.
__ andl(ECX, Immediate(~(1 << target::UntaggedObject::kNotMarkedBit)));
__ andl(ECX,
Immediate(~(1 << target::UntaggedObject::kOldAndNotMarkedBit)));
// Cmpxchgq: compare value = implicit operand EAX, new value = ECX.
// On failure, EAX is updated with the current value.
__ LockCmpxchgl(FieldAddress(EBX, target::Object::tags_offset()), ECX);