diff --git a/pkg/vm_service/test/add_breakpoint_rpc_kernel_test.dart b/pkg/vm_service/test/add_breakpoint_rpc_kernel_test.dart index 1020feeb37f..bc5b8a52a12 100644 --- a/pkg/vm_service/test/add_breakpoint_rpc_kernel_test.dart +++ b/pkg/vm_service/test/add_breakpoint_rpc_kernel_test.dart @@ -139,7 +139,7 @@ final tests = [ expect(e.code, RPCErrorKind.kCannotAddBreakpoint.code); expect( e.details, - 'addBreakpoint: Cannot add breakpoint at line $LINE_A. Error occurred ' + 'addBreakpoint: Cannot add breakpoint at $LINE_A:37. Error occurred ' 'when resolving breakpoint location: No debuggable code where ' 'breakpoint was requested.', ); diff --git a/runtime/observatory/tests/service/add_breakpoint_rpc_kernel_test.dart b/runtime/observatory/tests/service/add_breakpoint_rpc_kernel_test.dart index c05d9b7d675..57f53314669 100644 --- a/runtime/observatory/tests/service/add_breakpoint_rpc_kernel_test.dart +++ b/runtime/observatory/tests/service/add_breakpoint_rpc_kernel_test.dart @@ -98,7 +98,7 @@ var tests = [ expect(e.code, equals(ServerRpcException.kCannotAddBreakpoint)); expect( e.message, - 'addBreakpoint: Cannot add breakpoint at line $LINE_A. Error occurred ' + 'addBreakpoint: Cannot add breakpoint at $LINE_A:37. Error occurred ' 'when resolving breakpoint location: No debuggable code where ' 'breakpoint was requested.', ); diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc index eac70f28c44..39f52edc49d 100644 --- a/runtime/vm/service.cc +++ b/runtime/vm/service.cc @@ -4042,10 +4042,18 @@ static void AddBreakpointCommon(Thread* thread, Error::Handle(thread->isolate()->debugger()->SetBreakpointAtLineCol( script_uri, line, col, &bpt)); if (!error.IsNull()) { - js->PrintError(kCannotAddBreakpoint, - "%s: Cannot add breakpoint at line %s. Error occurred " - "when resolving breakpoint location: %s.", - js->method(), line_param, error.ToErrorCString()); + if (col_param != nullptr) { + js->PrintError( + kCannotAddBreakpoint, + "%s: Cannot add breakpoint at %s:%s. Error occurred when resolving " + "breakpoint location: %s.", + js->method(), line_param, col_param, error.ToErrorCString()); + } else { + js->PrintError(kCannotAddBreakpoint, + "%s: Cannot add breakpoint at line %s. Error occurred " + "when resolving breakpoint location: %s.", + js->method(), line_param, error.ToErrorCString()); + } return; } ASSERT(bpt != nullptr);