From 2f2cf796648bbf59afab2b50ed98cbe997b82355 Mon Sep 17 00:00:00 2001 From: pq Date: Wed, 16 Oct 2024 21:28:20 +0000 Subject: [PATCH] [server] bump SDK constraint; wildcards FTW! Change-Id: I35b68be178eb5518f12520dfd523162b0eb3428d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390583 Reviewed-by: Brian Wilkerson Reviewed-by: Konstantin Shcheglov Commit-Queue: Phil Quitslund --- .../src/services/completion/postfix/postfix_completion.dart | 2 +- pkg/analysis_server/pubspec.yaml | 2 +- pkg/analysis_server/test/lsp/error_or_test.dart | 6 +++--- .../test/src/services/correction/fix/remove_const_test.dart | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart index af4edfc022e..c353d4f421a 100644 --- a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart +++ b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart @@ -197,7 +197,7 @@ abstract final class DartPostfixCompletion { static bool _false(_) => false; - static Future _null(_, __) async => null; + static Future _null(_, _) async => null; } /// A description of a postfix completion. diff --git a/pkg/analysis_server/pubspec.yaml b/pkg/analysis_server/pubspec.yaml index 29ff9c0c220..1a573b3f272 100644 --- a/pkg/analysis_server/pubspec.yaml +++ b/pkg/analysis_server/pubspec.yaml @@ -3,7 +3,7 @@ name: analysis_server publish_to: none environment: - sdk: '>=3.3.0 <4.0.0' + sdk: '>=3.7.0-edge <4.0.0' # Use 'any' constraints here; we get our versions from the DEPS file. dependencies: diff --git a/pkg/analysis_server/test/lsp/error_or_test.dart b/pkg/analysis_server/test/lsp/error_or_test.dart index 760a6b47a26..d8e7bd3ab31 100644 --- a/pkg/analysis_server/test/lsp/error_or_test.dart +++ b/pkg/analysis_server/test/lsp/error_or_test.dart @@ -24,7 +24,7 @@ final errorY = error(ErrorCodes.ParseError, 'y'); class ErrorOrRecord2ExtensionTest { test_ifResults_error() { var called = false; - (success(1), errorX).ifResults((_, __) => called = true); + (success(1), errorX).ifResults((_, _) => called = true); expect(called, isFalse); } @@ -75,7 +75,7 @@ class ErrorOrRecord2ExtensionTest { class ErrorOrRecord3ExtensionTest { test_ifResults_error() { var called = false; - (success(1), success(1), errorX).ifResults((_, __, ___) => called = true); + (success(1), success(1), errorX).ifResults((_, _, _) => called = true); expect(called, isFalse); } @@ -132,7 +132,7 @@ class ErrorOrRecord4ExtensionTest { test_ifResults_error() { var called = false; (success(1), success(1), success(1), errorX) - .ifResults((_, __, ___, ____) => called = true); + .ifResults((_, _, _, _) => called = true); expect(called, isFalse); } diff --git a/pkg/analysis_server/test/src/services/correction/fix/remove_const_test.dart b/pkg/analysis_server/test/src/services/correction/fix/remove_const_test.dart index e11fdec8da5..c56e60d7471 100644 --- a/pkg/analysis_server/test/src/services/correction/fix/remove_const_test.dart +++ b/pkg/analysis_server/test/src/services/correction/fix/remove_const_test.dart @@ -141,7 +141,7 @@ var x = B(a: A(), b: const [0]); Future test_implicitConst_invalidConstant() async { await resolveTestCode(''' class A { - const A(_, __); + const A(_, _); } void f(bool b) { @@ -151,7 +151,7 @@ void f(bool b) { await assertHasFix(''' class A { - const A(_, __); + const A(_, _); } void f(bool b) {