From 2e87f8c95a699bdcd672c7fbd4e3083faba3220f Mon Sep 17 00:00:00 2001 From: Daco Harkes Date: Wed, 26 Jul 2023 16:02:56 +0000 Subject: [PATCH] [tools] Fixes to find_builders.dart Fixes the Gerrit CL footer. Denylists some builders which are not available on CQ but only on CI. Change-Id: Ie0716c52366a8be429c2b6aca030e61769ceca80 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316382 Reviewed-by: William Hesse Auto-Submit: Daco Harkes Commit-Queue: Daco Harkes --- tools/find_builders.dart | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tools/find_builders.dart b/tools/find_builders.dart index a6f3d9a10a0..8c4157a7862 100755 --- a/tools/find_builders.dart +++ b/tools/find_builders.dart @@ -27,12 +27,13 @@ Future main(List args) async { for (final testName in testNames) ...await _testGetConfigurations(testName), }); final configurationBuilders = await _configurationBuilders(); - final builders = { - for (final config in configurations) configurationBuilders[config] - }.toList() + final builders = _filterBuilders( + {for (final config in configurations) configurationBuilders[config]!}, + ).toList() ..sort(); - print('Cq-Include-Trybots: luci.dart.try:${builders.join(',')}'); + final gerritTryList = builders.map((b) => '$b-try').join(','); + print('Cq-Include-Trybots: luci.dart.try:$gerritTryList'); } Future> _testGetConfigurations(String testName) async { @@ -73,9 +74,18 @@ Iterable _filterConfigurations(Set configs) { return result..sort(); } +Iterable _filterBuilders(Iterable builders) { + return builders.where((b) => !_ciOnlyBuilders.contains(b)); +} + +const _ciOnlyBuilders = { + 'vm-aot-linux-release-arm64', + 'vm-linux-release-arm64', +}; + Stream> _configurationDocuments() async* { String? nextPageToken; - while (true) { + do { final requestUrl = Uri( scheme: 'https', host: 'firestore.googleapis.com', @@ -91,10 +101,7 @@ Stream> _configurationDocuments() async* { object['documents'].cast>()); nextPageToken = object['nextPageToken']; - if (nextPageToken == null) { - break; - } - } + } while (nextPageToken != null); } Future> _configurationBuilders() async {