From 2d3c9f4346ada89f955b028288c8d04495e41b3f Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Mon, 13 Feb 2023 23:44:59 +0000 Subject: [PATCH] [dart2js, ddc] Skip flaky tests These tests are flipping between Fail, Pass, Flaky at a rate that is avoiding flake detection. Skipping until we can address the issues. Issue: https://github.com/dart-lang/sdk/issues/51086 Issue: https://github.com/dart-lang/sdk/issues/50718 Change-Id: I9a6aa25bdc1573fe1af8783c7ddb389282695540 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282810 Commit-Queue: Nicholas Shahan Reviewed-by: Sigmund Cherem --- tests/co19/co19-dart2js.status | 4 ++++ tests/co19_2/co19_2-dart2js.status | 4 ++++ tests/corelib/corelib.status | 7 +++++++ tests/corelib_2/corelib_2.status | 7 +++++++ tests/language/language_dart2js.status | 1 + tests/language/language_dartdevc.status | 1 + tests/language_2/language_2_dart2js.status | 1 + tests/language_2/language_2_dartdevc.status | 1 + tests/lib/lib_dart2js.status | 6 ++++++ tests/lib_2/lib_2_dart2js.status | 6 ++++++ 10 files changed, 38 insertions(+) diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status index ea384438e06..f93d019b91d 100644 --- a/tests/co19/co19-dart2js.status +++ b/tests/co19/co19-dart2js.status @@ -103,3 +103,7 @@ LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # slow babeljs tr LibTest/core/List/List_class_A01_t04: SkipSlow # slow babeljs transformation LibTest/core/List/List_class_A01_t05: SkipSlow # slow babeljs transformation LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation + +[ $compiler == dart2js && $runtime == safari ] +LibTest/html/Element/isContentEditable_A02_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +LibTest/html/IFrameElement/isContentEditable_A01_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 diff --git a/tests/co19_2/co19_2-dart2js.status b/tests/co19_2/co19_2-dart2js.status index a63fb39eb7d..b027c8b66b9 100644 --- a/tests/co19_2/co19_2-dart2js.status +++ b/tests/co19_2/co19_2-dart2js.status @@ -79,3 +79,7 @@ LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # slow babeljs tr LibTest/core/List/List_class_A01_t04: SkipSlow # slow babeljs transformation LibTest/core/List/List_class_A01_t05: SkipSlow # slow babeljs transformation LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation + +[ $compiler == dart2js && $runtime == safari ] +LibTest/html/Element/isContentEditable_A02_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +LibTest/html/IFrameElement/isContentEditable_A01_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 diff --git a/tests/corelib/corelib.status b/tests/corelib/corelib.status index 8b2b7d8207f..17c47f566f0 100644 --- a/tests/corelib/corelib.status +++ b/tests/corelib/corelib.status @@ -32,6 +32,13 @@ bigint_js_test: SkipByDesign # JavaScript-specific test [ $compiler == dart2js && $runtime != none ] regexp/pcre_test: Slow, Pass # Issue 21593 +[ $compiler == dart2js && $runtime == safari ] +date_time11_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +local_date_time_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-property-char-class_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-property-invalid_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-regexp-restricted-syntax_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 + [ $runtime != dart_precompiled && $runtime != vm ] reg_exp_receive_port_test: SkipByDesign # uses SendPort/ReceivePort diff --git a/tests/corelib_2/corelib_2.status b/tests/corelib_2/corelib_2.status index 5810b373148..0c8b7994e98 100644 --- a/tests/corelib_2/corelib_2.status +++ b/tests/corelib_2/corelib_2.status @@ -35,6 +35,13 @@ bigint_js_test: SkipByDesign # JavaScript-specific test [ $compiler == dart2js && $runtime != none ] regexp/pcre_test: Slow, Pass # Issue 21593 +[ $compiler == dart2js && $runtime == safari ] +date_time11_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +local_date_time_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-property-char-class_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-property-invalid_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +regexp/unicode-regexp-restricted-syntax_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 + [ $runtime != dart_precompiled && $runtime != vm ] reg_exp_receive_port_test: SkipByDesign # uses SendPort/ReceivePort diff --git a/tests/language/language_dart2js.status b/tests/language/language_dart2js.status index 1c44dac1f9d..8a0db5928cb 100644 --- a/tests/language/language_dart2js.status +++ b/tests/language/language_dart2js.status @@ -4,6 +4,7 @@ # Sections in this file should contain "$compiler == dart2js". [ $compiler == dart2js ] +async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported mixin_method_override_test/G5: Skip # Issue 34354 number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics diff --git a/tests/language/language_dartdevc.status b/tests/language/language_dartdevc.status index a8ba26092b0..d133e2e058c 100644 --- a/tests/language/language_dartdevc.status +++ b/tests/language/language_dartdevc.status @@ -5,6 +5,7 @@ # Sections in this file should contain "$compiler == dartdevc", dartdevk or ddc. [ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 async_star/throw_in_catch_test: Skip # Times out. Issue 29920 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics. diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index 1c44dac1f9d..8a0db5928cb 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -4,6 +4,7 @@ # Sections in this file should contain "$compiler == dart2js". [ $compiler == dart2js ] +async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported mixin_method_override_test/G5: Skip # Issue 34354 number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index fbe8b0b0f49..77f99ef9112 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -8,6 +8,7 @@ async/return_throw_test: Skip # Flaky but not enough to be detected. Re-enable pending a decision on the correct behavior. https://github.com/dart-lang/sdk/issues/44395 [ $compiler == dartdevc || $compiler == dartdevk || $compiler == ddc ] +async_star/async_star_await_for_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/51086 async_star/throw_in_catch_test: Skip # Times out. Issue 29920 external_abstract_fields/external_fields_test: SkipByDesign # Non-JS-interop external members are not supported number/int64_literal_runtime*_test: Skip # This is testing Dart 2.0 int64 semantics. diff --git a/tests/lib/lib_dart2js.status b/tests/lib/lib_dart2js.status index c7caca51aeb..4470bd53320 100644 --- a/tests/lib/lib_dart2js.status +++ b/tests/lib/lib_dart2js.status @@ -59,10 +59,16 @@ html/history_test: Skip # Issue 22050 html/request_animation_frame_test: Skip # Async test hangs. [ $compiler == dart2js && $runtime == safari ] +html/audiocontext_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 html/callback_list_test: SkipByDesign # FileSystem not supported in Safari. html/file_sample_test: Skip # FileSystem not supported on Safari. html/fileapi_supported_throws_test: Skip # FileSystem not supported on Safari +html/input_element_date_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +html/input_element_datetime_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +html/input_element_time_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 html/interactive_media_test: SkipSlow +html/mediasource_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +js/js_util/bigint_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 [ $compiler == dart2js && $system == linux ] html/interactive_geolocation_test: Skip # Requires allowing geo location. diff --git a/tests/lib_2/lib_2_dart2js.status b/tests/lib_2/lib_2_dart2js.status index 39852b51637..3279ef253f8 100644 --- a/tests/lib_2/lib_2_dart2js.status +++ b/tests/lib_2/lib_2_dart2js.status @@ -57,10 +57,16 @@ html/history_test: Skip # Issue 22050 html/request_animation_frame_test: Skip # Async test hangs. [ $compiler == dart2js && $runtime == safari ] +html/audiocontext_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 html/callback_list_test: SkipByDesign # FileSystem not supported in Safari. html/file_sample_test: Skip # FileSystem not supported on Safari. html/fileapi_supported_throws_test: Skip # FileSystem not supported on Safari +html/input_element_date_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +html/input_element_datetime_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +html/input_element_time_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 html/interactive_media_test: SkipSlow +html/mediasource_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 +js/js_util/bigint_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718 [ $compiler == dart2js && $system == linux ] html/interactive_geolocation_test: Skip # Requires allowing geo location.