From 2cd2bed059ccca2cfad949b28af313825eaf92ff Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Fri, 11 Aug 2023 21:06:10 +0000 Subject: [PATCH] [gardening] Make standalone/package/package_isolate_test a no-op in AOT. The test relies on spawning some other dart helper scripts, which is not supported for AOT tests at the moment. BUG=https://github.com/dart-lang/sdk/issues/53195 TEST=ci Change-Id: Id083440227f5cf446c296c9ca561ab2147c0da75 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/320200 Reviewed-by: Ryan Macnak Commit-Queue: Alexander Aprelev --- .../package/.dart_tool/package_config.json | 6 ++++++ tests/standalone/package/package_isolate_test.dart | 12 +++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/standalone/package/.dart_tool/package_config.json b/tests/standalone/package/.dart_tool/package_config.json index 2b09ae93a6e..3c4394c1edc 100644 --- a/tests/standalone/package/.dart_tool/package_config.json +++ b/tests/standalone/package/.dart_tool/package_config.json @@ -13,6 +13,12 @@ "packageUri": "lib/", "languageVersion": "2.12" }, + { + "name": "path", + "rootUri": "../../../../third_party/pkg/path", + "packageUri": "lib/", + "languageVersion": "3.0" + }, { "name": "lib1", "rootUri": "../pkgs/lib1" diff --git a/tests/standalone/package/package_isolate_test.dart b/tests/standalone/package/package_isolate_test.dart index 43fb34ebbbc..799a15c8f6f 100644 --- a/tests/standalone/package/package_isolate_test.dart +++ b/tests/standalone/package/package_isolate_test.dart @@ -8,8 +8,11 @@ library package_isolate_test; -import 'pkgs/shared/shared.dart' as shared; +import 'dart:io'; import 'dart:isolate'; +import 'package:path/path.dart' as path; + +import 'pkgs/shared/shared.dart' as shared; import '../../../pkg/async_helper/lib/async_helper.dart'; import '../../../pkg/expect/lib/expect.dart'; @@ -26,6 +29,13 @@ ReceivePort expectResponse() { } void main() { + // No support for tests that attempt to Isolate.spawnUri() in AOT of some + // script other than self. + if (path.basenameWithoutExtension(Platform.executable) == + "dart_precompiled_runtime") { + return; + } + { final replyPort = expectResponse().sendPort; shared.output = 'main';