dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[kernel/cfe/etc] Split outline transformation into performOutlineTransformations and performOutlineComponentOperations"

Browse Source 
This reverts commit b3d9c8a297.

Reason for revert: b/503506653

Original change's description:
> [kernel/cfe/etc] Split outline transformation into performOutlineTransformations and performOutlineComponentOperations
>
> Currently outline transformations aren't run via the incremental
> compiler which causes problems in
> https://dart-review.googlesource.com/c/sdk/+/491702 which fixes it by
> calling the current transformation in the incremental compiler. This
> calls it twice though (because it's run again in
> `frontend_server/lib/compute_kernel.dart`, but removing it there doesn't
> work because a filtering is done which doesn't apply through the
> incremental compiler.
>
> This CL splits up the outline transformation stage into a call that can
> actually transform the libraries and one that can do the filtering,
> which should fix the issue.
>
> Change-Id: I5ae3477ebfe580dca372ea792924cdfb79979b35
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/495700
> Commit-Queue: Jens Johansen <jensj@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I961a7d2e09f64f4b2e4dc9e45e1f3572f3f2cdeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/496260
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jens Johansen <jensj@google.com>
This commit is contained in:
Ivan Inozemtsev
2026-04-17 06:10:08 -07:00
committed by dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent 4c89523e4f
commit 264098c85f
4 changed files with 6 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/kernel/lib/target/targets.dart
+5 -21
View File
@@ -334,24 +334,13 @@ abstract class Target {
/// Perform target-specific transformations on the outlines stored in
/// [Component] when generating summaries.
///
/// This is used to transforming the libraries, but not for instance
/// filtering the output libraries or adding metadata. Do this in
/// [performOutlineComponentOperations] instead.
/// This transformation is not applied when compiling full kernel programs to
/// This transformation is used to add metadata on outlines and to filter
/// unnecessary information before generating program summaries. This
/// transformation is not applied when compiling full kernel programs to
/// prevent affecting the internal invariants of the compiler and accidentally
/// slowing down compilation.
void performOutlineTransformations(Component component) {}
/// Perform target-specific operations on the [Component] storing the outlines
/// when generating summaries.
///
/// This is not for transforming the libraries, but can be used to add
/// metadata and filter libraries.
/// This is not applied when compiling full kernel programs to prevent
/// affecting the internal invariants of the compiler and accidentally
/// slowing down compilation.
void performOutlineComponentOperations(Component component) {}
/// Perform target-specific transformations on the given libraries that must
/// run before constant evaluation.
void performPreConstantEvaluationTransformations(
@@ -1033,11 +1022,6 @@ class TargetWrapper extends Target {
_target.performOutlineTransformations(component);
}
@override
void performOutlineComponentOperations(Component component) {
_target.performOutlineComponentOperations(component);
}
@override
void performPreConstantEvaluationTransformations(
Component component,
@@ -1116,8 +1100,8 @@ mixin SummaryMixin on Target {
bool get excludeNonSources;
@override
void performOutlineComponentOperations(Component component) {
super.performOutlineComponentOperations(component);
void performOutlineTransformations(Component component) {
super.performOutlineTransformations(component);
if (!excludeNonSources) return;
List<Library> libraries = new List.of(component.libraries);