From 1f9029339898ec9dae84b5faf547f130fda6c97e Mon Sep 17 00:00:00 2001 From: Alexander Markov Date: Fri, 21 Mar 2025 07:40:20 -0700 Subject: [PATCH] [gardening] Fix gcc build of samples/embedder GCC doesn't like // comments which are not terminated due to \ at the end of line. TEST=ci Change-Id: I9d6188bf1db9358804b488d73bef88ba5e6b4f39 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417220 Commit-Queue: Alexander Markov Reviewed-by: Tess Strickland --- pkg/vm/tool/generate_entry_point_shims.dart | 12 +++++++----- samples/embedder/timer.cc | 12 +++++++----- samples/embedder/timer.h | 12 +++++++----- 3 files changed, 21 insertions(+), 15 deletions(-) diff --git a/pkg/vm/tool/generate_entry_point_shims.dart b/pkg/vm/tool/generate_entry_point_shims.dart index 2d5d4060965..182a6561a13 100644 --- a/pkg/vm/tool/generate_entry_point_shims.dart +++ b/pkg/vm/tool/generate_entry_point_shims.dart @@ -112,18 +112,20 @@ void main(List args) async { for (final buffer in [declarations, definitions]) { buffer.write(''' -// Generated with: -// dart pkg/vm/tools/generate_entry_point_shims.dart \\ -// '''); +/* + Generated with: + dart pkg/vm/tool/generate_entry_point_shims.dart \\ + '''); if (createUninitializedInstanceMethods) { buffer.write('-u '); } if (uriString != null) { buffer.write('''-p $uriString \\ -// '''); + '''); } buffer.writeln('''$source \\ -// $outputPath + $outputPath +*/ '''); } diff --git a/samples/embedder/timer.cc b/samples/embedder/timer.cc index f4b10fc8e51..dafe194ba2d 100644 --- a/samples/embedder/timer.cc +++ b/samples/embedder/timer.cc @@ -1,11 +1,13 @@ // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// -// Generated with: -// dart pkg/vm/tools/generate_entry_point_shims.dart \ -// out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \ -// samples/embedder/timer + +/* + Generated with: + dart pkg/vm/tool/generate_entry_point_shims.dart \ + out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \ + samples/embedder/timer +*/ #include "timer.h" diff --git a/samples/embedder/timer.h b/samples/embedder/timer.h index 10d207e9cff..ede2feb0531 100644 --- a/samples/embedder/timer.h +++ b/samples/embedder/timer.h @@ -1,11 +1,13 @@ // Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -// -// Generated with: -// dart pkg/vm/tools/generate_entry_point_shims.dart \ -// out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \ -// samples/embedder/timer + +/* + Generated with: + dart pkg/vm/tool/generate_entry_point_shims.dart \ + out/ReleaseX64/gen/samples/embedder/timer_aot.dart.dill \ + samples/embedder/timer +*/ #ifndef SAMPLES_EMBEDDER_TIMER_H #define SAMPLES_EMBEDDER_TIMER_H