diff --git a/DEPS b/DEPS index 851c89d36bf..634a8d07c71 100644 --- a/DEPS +++ b/DEPS @@ -157,7 +157,7 @@ vars = { "intl_rev": "5d65e3808ce40e6282e40881492607df4e35669f", "json_rpc_2_rev": "b4810dc7bee5828f240586c81f3f34853cacdbce", "leak_tracker_rev": "f5620600a5ce1c44f65ddaa02001e200b096e14c", # manually rolled - "lints_rev": "af68bf0cbad88002a2ae19ee8db37b64eb120c32", + "lints_rev": "a97011b4b031b1df94765dbacd7d92b0b765c8b9", "logging_rev": "8752902b75a476d2c7b64dcf01aaaee885f35c4c", "markdown_rev": "f6eaea38146d8901756418c4e7123eb7bd77249e", "matcher_rev": "d6d573d0f8d65b36550ce62aad3ce6b5e987b642", diff --git a/pkg/_macros/analysis_options.yaml b/pkg/_macros/analysis_options.yaml index b761641c40e..737816121cd 100644 --- a/pkg/_macros/analysis_options.yaml +++ b/pkg/_macros/analysis_options.yaml @@ -4,6 +4,8 @@ analyzer: language: strict-casts: true errors: + # Remove on next publish or protocol refactoring: + unintended_html_in_doc_comment: ignore # Remove on next publish or protocol refactoring; # https://github.com/dart-lang/language/issues/3706. unnecessary_library_name: ignore diff --git a/pkg/analysis_server/analysis_options.yaml b/pkg/analysis_server/analysis_options.yaml index ff5057d7597..09e91c26512 100644 --- a/pkg/analysis_server/analysis_options.yaml +++ b/pkg/analysis_server/analysis_options.yaml @@ -24,6 +24,8 @@ analyzer: non_constant_identifier_names: ignore overridden_fields: ignore todo: ignore + # Existing violations (361) + unintended_html_in_doc_comment: ignore linter: rules: diff --git a/pkg/analysis_server_client/analysis_options.yaml b/pkg/analysis_server_client/analysis_options.yaml index dada431af9f..486deaf63cf 100644 --- a/pkg/analysis_server_client/analysis_options.yaml +++ b/pkg/analysis_server_client/analysis_options.yaml @@ -4,6 +4,8 @@ analyzer: errors: constant_identifier_names: ignore non_constant_identifier_names: ignore + # Existing violations (109) + unintended_html_in_doc_comment: ignore linter: rules: diff --git a/pkg/analyzer/lib/dart/element/element.dart b/pkg/analyzer/lib/dart/element/element.dart index 9a01ac67653..655aab36ac1 100644 --- a/pkg/analyzer/lib/dart/element/element.dart +++ b/pkg/analyzer/lib/dart/element/element.dart @@ -2575,7 +2575,9 @@ abstract class TypeAliasElement /// Note that this always instantiates the typedef itself, so for a /// [TypeAliasElement] the returned [DartType] might still be a generic /// type, with type formals. For example, if the typedef is: + /// /// typedef F = void Function(T, U); + /// /// then `F` will produce `void Function(int, U)`. DartType instantiate({ required List typeArguments, diff --git a/pkg/analyzer/lib/dart/element/element2.dart b/pkg/analyzer/lib/dart/element/element2.dart index 4683bf2897b..3ff8e48a698 100644 --- a/pkg/analyzer/lib/dart/element/element2.dart +++ b/pkg/analyzer/lib/dart/element/element2.dart @@ -1800,7 +1800,9 @@ abstract class TypeAliasElement2 /// Note that this always instantiates the typedef itself, so for a /// [TypeAliasElement2] the returned [DartType] might still be a generic /// type, with type formals. For example, if the typedef is: + /// /// typedef F = void Function(T, U); + /// /// then `F` will produce `void Function(int, U)`. DartType instantiate({ required List typeArguments, diff --git a/pkg/analyzer/lib/dart/element/type.dart b/pkg/analyzer/lib/dart/element/type.dart index d8f71050fee..845b75bc9cf 100644 --- a/pkg/analyzer/lib/dart/element/type.dart +++ b/pkg/analyzer/lib/dart/element/type.dart @@ -70,7 +70,7 @@ abstract class DartType implements SharedTypeStructure { /// dart:async library. bool get isDartAsyncFuture; - /// Return `true` if this type represents the type 'FutureOr' defined in + /// Return `true` if this type represents the type `FutureOr` defined in /// the dart:async library. bool get isDartAsyncFutureOr; diff --git a/pkg/analyzer/lib/src/dart/element/normalize.dart b/pkg/analyzer/lib/src/dart/element/normalize.dart index 64dd0b6ceaf..30bff1398b7 100644 --- a/pkg/analyzer/lib/src/dart/element/normalize.dart +++ b/pkg/analyzer/lib/src/dart/element/normalize.dart @@ -29,7 +29,7 @@ class NormalizeHelper { return _normalize(T); } - /// NORM(R Function(S)) = R1 Function(X extends B1>(S1) + /// `NORM(R Function(S)) = R1 Function(X extends B1>(S1)` /// * where R1 = NORM(R) /// * and B1 = NORM(B) /// * and S1 = NORM(S) @@ -57,7 +57,7 @@ class NormalizeHelper { ); } - /// NORM(FutureOr) + /// `NORM(FutureOr)` DartType _futureOr(InterfaceType T) { // * let S be NORM(T) var S = _normalize(T.typeArguments[0]); diff --git a/pkg/analyzer/lib/src/summary2/data_reader.dart b/pkg/analyzer/lib/src/summary2/data_reader.dart index e8cce2492b2..adacc3bbc5e 100644 --- a/pkg/analyzer/lib/src/summary2/data_reader.dart +++ b/pkg/analyzer/lib/src/summary2/data_reader.dart @@ -217,10 +217,10 @@ class _StringTable { late final List _strings; /// The structure of the table: - /// - /// <-- [startOffset] - /// - /// + /// - `` + /// - ` <-- [startOffset]` + /// - `` + /// - `` _StringTable({ required Uint8List bytes, required int startOffset, diff --git a/pkg/analyzer/test/src/dart/element/normalize_type_test.dart b/pkg/analyzer/test/src/dart/element/normalize_type_test.dart index eb8da11f1d4..cc30ec2b47c 100644 --- a/pkg/analyzer/test/src/dart/element/normalize_type_test.dart +++ b/pkg/analyzer/test/src/dart/element/normalize_type_test.dart @@ -254,7 +254,7 @@ class NormalizeTypeTest extends AbstractTypeSystemTest with StringTypes { ); } - /// NORM(FutureOr) + /// `NORM(FutureOr)` /// * let S be NORM(T) test_futureOr() { void check(DartType T, DartType expected) { diff --git a/pkg/analyzer/test/src/dart/element/type_constraint_gatherer_test.dart b/pkg/analyzer/test/src/dart/element/type_constraint_gatherer_test.dart index 7baeadde161..3733b4664a1 100644 --- a/pkg/analyzer/test/src/dart/element/type_constraint_gatherer_test.dart +++ b/pkg/analyzer/test/src/dart/element/type_constraint_gatherer_test.dart @@ -590,7 +590,7 @@ class TypeConstraintGathererTest extends AbstractTypeSystemTest { ); } - /// If `P` is `C and `Q` is `C`, then the match + /// If `P` is `C` and `Q` is `C`, then the match /// holds under constraints `C0 + ... + Ck`: /// If `Mi` is a subtype match for `Ni` with respect to L under /// constraints `Ci`. diff --git a/pkg/analyzer/test/src/dart/element/upper_lower_bound_test.dart b/pkg/analyzer/test/src/dart/element/upper_lower_bound_test.dart index 0f8e309dc89..dcd75863ae1 100644 --- a/pkg/analyzer/test/src/dart/element/upper_lower_bound_test.dart +++ b/pkg/analyzer/test/src/dart/element/upper_lower_bound_test.dart @@ -2635,8 +2635,8 @@ class UpperBoundTest extends _BoundsTestBase { ); } - /// UP(Future, FutureOr) = FutureOr where T3 = UP(T1, T2) - /// UP(FutureOr, Future) = FutureOr where T3 = UP(T1, T2) + /// `UP(Future, FutureOr) = FutureOr where T3 = UP(T1, T2)` + /// `UP(FutureOr, Future) = FutureOr where T3 = UP(T1, T2)` test_futureOr_future() { void check(DartType T1, DartType T2, DartType expected) { _checkLeastUpperBound( @@ -2650,7 +2650,7 @@ class UpperBoundTest extends _BoundsTestBase { check(intNone, stringNone, objectNone); } - /// UP(FutureOr, FutureOr) = FutureOr where T3 = UP(T1, T2) + /// `UP(FutureOr, FutureOr) = FutureOr where T3 = UP(T1, T2)` test_futureOr_futureOr() { void check(DartType T1, DartType T2, DartType expected) { _checkLeastUpperBound( @@ -2664,8 +2664,8 @@ class UpperBoundTest extends _BoundsTestBase { check(intNone, stringNone, objectNone); } - /// UP(T1, FutureOr) = FutureOr where T3 = UP(T1, T2) - /// UP(FutureOr, T2) = FutureOr where T3 = UP(T1, T2) + /// `UP(T1, FutureOr) = FutureOr where T3 = UP(T1, T2)` + /// `UP(FutureOr, T2) = FutureOr where T3 = UP(T1, T2)` test_futureOr_other() { void check(DartType T1, DartType T2, DartType expected) { _checkLeastUpperBound( diff --git a/pkg/analyzer_plugin/analysis_options.yaml b/pkg/analyzer_plugin/analysis_options.yaml index 1525ab8f2a9..c130630a0df 100644 --- a/pkg/analyzer_plugin/analysis_options.yaml +++ b/pkg/analyzer_plugin/analysis_options.yaml @@ -11,6 +11,8 @@ analyzer: non_constant_identifier_names: ignore # Existing violations (3) library_private_types_in_public_api: ignore + # Existing violations (194) + unintended_html_in_doc_comment: ignore linter: rules: diff --git a/pkg/dart2js_info/bin/src/to_devtools_format.dart b/pkg/dart2js_info/bin/src/to_devtools_format.dart index b310f5248e8..c53818703b4 100644 --- a/pkg/dart2js_info/bin/src/to_devtools_format.dart +++ b/pkg/dart2js_info/bin/src/to_devtools_format.dart @@ -144,7 +144,7 @@ class ProgramInfoBuilder extends VMProgramInfoVisitor { /// [PackageInfo] objects. final Map packageInfos = {}; - /// Mapping between an [LibraryInfo] object and the name of the + /// Mapping between an `` [LibraryInfo] object and the name of the /// corresponding [vm.ProgramInfoNode] object. final Map unnamedLibraries = {}; diff --git a/pkg/dart2wasm/lib/await_transformer.dart b/pkg/dart2wasm/lib/await_transformer.dart index 71758912c87..843cd6478c1 100644 --- a/pkg/dart2wasm/lib/await_transformer.dart +++ b/pkg/dart2wasm/lib/await_transformer.dart @@ -12,7 +12,7 @@ import 'state_machine.dart' as stateMachineCodeGen; /// This pass lifts `await` expressions to the top-level. After the pass, all /// `await` expressions will have the form: /// -/// final $temp = await ; +/// final $temp = await ; /// /// where `` is an expression without `await`. /// diff --git a/pkg/dart2wasm/lib/ffi_native_transformer.dart b/pkg/dart2wasm/lib/ffi_native_transformer.dart index d62bd68bad6..c6db9664177 100644 --- a/pkg/dart2wasm/lib/ffi_native_transformer.dart +++ b/pkg/dart2wasm/lib/ffi_native_transformer.dart @@ -23,15 +23,15 @@ import 'abi.dart' show kWasmAbiEnumIndex; /// /// Example: /// -/// @Native(symbol: "addInt8") -/// external int addInt8(int a, int b); +/// @Native(symbol: "addInt8") +/// external int addInt8(int a, int b); /// /// Converted to: /// -/// external static wasm::WasmI32 addInt8_$import(wasm::WasmI32 a, wasm::WasmI32 b); +/// external static wasm::WasmI32 addInt8_$import(wasm::WasmI32 a, wasm::WasmI32 b); /// -/// static int addInt8(int a, int b) => -/// addInt8_$import(WasmI32::int8FromInt(a), WasmI32::int8FromInt(b)).toIntSigned(); +/// static int addInt8(int a, int b) => +/// addInt8_$import(WasmI32::int8FromInt(a), WasmI32::int8FromInt(b)).toIntSigned(); /// void transformLibraries( Component component, diff --git a/pkg/dart2wasm/lib/js/callback_specializer.dart b/pkg/dart2wasm/lib/js/callback_specializer.dart index 62cbed10434..838188fccb4 100644 --- a/pkg/dart2wasm/lib/js/callback_specializer.dart +++ b/pkg/dart2wasm/lib/js/callback_specializer.dart @@ -254,10 +254,10 @@ class CallbackSpecializer { /// Lowers an invocation of `allowInterop(foo)` to: /// - /// let #var = foo in - /// _isDartFunctionWrapped(#var) ? - /// #var : - /// _wrapDartFunction(#var, jsWrapperFunction(#var)); + /// let #var = foo in + /// _isDartFunctionWrapped(#var) ? + /// #var : + /// _wrapDartFunction(#var, jsWrapperFunction(#var)); /// /// The use of two functions here is necessary because we do not allow /// `WasmExternRef` to be an argument or return type for a tear off. @@ -346,11 +346,11 @@ class CallbackSpecializer { /// Given an invocation of `Function.toJS`, returns an [Expression] /// representing: /// - /// JSValue(jsWrapperFunction()) + /// JSValue(jsWrapperFunction()) /// /// or if a cast closure is needed: /// - /// JSValue(jsWrapperFunction(, )) + /// JSValue(jsWrapperFunction(, )) /// /// If [captureThis] is true, this is assumed to be an invocation of /// `Function.toJSCaptureThis`. diff --git a/pkg/dart2wasm/lib/transformers.dart b/pkg/dart2wasm/lib/transformers.dart index dac76711569..1cb91bee027 100644 --- a/pkg/dart2wasm/lib/transformers.dart +++ b/pkg/dart2wasm/lib/transformers.dart @@ -781,21 +781,21 @@ class _AsyncStarFrame { /// Converts `pushWasmArray(array, length, elem, nextCapacity)` to: /// -/// if (array.length == length) { -/// final newArray = WasmArray(nextCapacity); -/// newArray.copy(0, array, 0, length); -/// array = newArray; -/// } -/// array[length] = elem; -/// length += 1; +/// if (array.length == length) { +/// final newArray = WasmArray(nextCapacity); +/// newArray.copy(0, array, 0, length); +/// array = newArray; +/// } +/// array[length] = elem; +/// length += 1; /// /// and `popWasmArray(array, length)` to block expression: /// -/// { -/// length -= 1; -/// final T _value = array[length]; -/// array[length] = null; -/// } => _value +/// { +/// length -= 1; +/// final T _value = array[length]; +/// array[length] = null; +/// } => _value /// /// This allows unboxing growable list in class fields. /// diff --git a/pkg/dart2wasm/lib/translator.dart b/pkg/dart2wasm/lib/translator.dart index c738dd04b5e..63a8d3f3c39 100644 --- a/pkg/dart2wasm/lib/translator.dart +++ b/pkg/dart2wasm/lib/translator.dart @@ -1251,7 +1251,7 @@ class Translator with KernelNodes { b.i32_wrap_i64(); } - /// Get the WasmListBase._data field of type WasmArray. + /// Get the `WasmListBase._data` field of type `WasmArray`. void getListBaseArray(w.InstructionsBuilder b) { ClassInfo info = classInfo[listBaseClass]!; b.struct_get(info.struct, FieldIndex.listArray); diff --git a/pkg/dev_compiler/lib/src/compiler/rewrite_async.dart b/pkg/dev_compiler/lib/src/compiler/rewrite_async.dart index 99a5ffe3b69..0c50c8f978b 100644 --- a/pkg/dev_compiler/lib/src/compiler/rewrite_async.dart +++ b/pkg/dev_compiler/lib/src/compiler/rewrite_async.dart @@ -391,8 +391,10 @@ abstract class AsyncRewriterBase extends js_ast.NodeVisitor { /// body. /// /// We cannot simply rewrite `.m()` to: + /// /// temp = .m; /// temp(); + /// /// Because this leaves `this` unbound in the call. To solve this we `bind` /// the receiver to the tear-off to re-establish the `this` context. /// diff --git a/pkg/dev_compiler/lib/src/kernel/module_symbols.dart b/pkg/dev_compiler/lib/src/kernel/module_symbols.dart index a0afb7126ff..fcd5684504a 100644 --- a/pkg/dev_compiler/lib/src/kernel/module_symbols.dart +++ b/pkg/dev_compiler/lib/src/kernel/module_symbols.dart @@ -195,7 +195,7 @@ class Symbol implements SymbolTableElement { /// Unique Id, shared with JS representation (if any). /// - /// '|' + /// `'|'` /// /// Where scope refers to a Library, Class, Function, or Scope. String get id => scopeId == null ? localId : '$scopeId|$localId'; @@ -433,7 +433,8 @@ class FunctionSymbol extends ScopeSymbol { /// Unique Id, shared with JS representation (if any). /// /// Format: - /// '|' + /// + /// '|' /// /// Where scope refers to a Library, Class, Function, or Scope. /// String id; diff --git a/pkg/dev_compiler/lib/src/kernel/type_environment.dart b/pkg/dev_compiler/lib/src/kernel/type_environment.dart index 64ea5361f25..a703dc90c97 100644 --- a/pkg/dev_compiler/lib/src/kernel/type_environment.dart +++ b/pkg/dev_compiler/lib/src/kernel/type_environment.dart @@ -27,11 +27,14 @@ abstract class DDCTypeEnvironment { /// Returns all class type parameters in this type environment. /// /// For the example: + /// + /// ``` /// Class Foo { /// method { /// ... // this /// } /// } + /// ``` /// /// classTypeParameters in this would return ['T']. List get classTypeParameters; @@ -39,11 +42,14 @@ abstract class DDCTypeEnvironment { /// Returns all class type parameters in this type environment. /// /// For the example: + /// + /// ``` /// Class Foo { /// method { /// ... // this /// } /// } + /// ``` /// /// functionTypeParameters this would return ['U']. List get functionTypeParameters; diff --git a/pkg/native_stack_traces/lib/src/convert.dart b/pkg/native_stack_traces/lib/src/convert.dart index 7dd554b9fd5..a8241606cf8 100644 --- a/pkg/native_stack_traces/lib/src/convert.dart +++ b/pkg/native_stack_traces/lib/src/convert.dart @@ -385,8 +385,8 @@ class StackTraceHeader { return null; } -/// Parses strings of the format +, where -/// is one of the static symbols used for Dart instruction +/// Parses strings of the format `+`, where +/// `` is one of the static symbols used for Dart instruction /// sections. /// /// Unless forceHexadecimal is true, an integer offset without a "0x" prefix or @@ -418,7 +418,7 @@ PCOffset? tryParseSymbolOffset(String s, /// - The location of the virtual address, which is one of the following: /// - A dynamic symbol name, a plus sign, and an integer offset. /// - The path to the snapshot, if it was loaded as a dynamic library, -/// otherwise the string "". +/// otherwise the string `""`. const _symbolOffsetREString = r'(?' + constants.vmSymbolName + r'|' + diff --git a/pkg/reload_test/lib/frontend_server_controller.dart b/pkg/reload_test/lib/frontend_server_controller.dart index bf4e19ea923..f782deb7160 100644 --- a/pkg/reload_test/lib/frontend_server_controller.dart +++ b/pkg/reload_test/lib/frontend_server_controller.dart @@ -48,6 +48,8 @@ enum FrontendServerState { /// Controls and synchronizes the Frontend Server during hot reloaad tests. /// /// The Frontend Server accepts the following instructions: +/// +/// ``` /// > compile /// /// > recompile [] @@ -65,6 +67,7 @@ enum FrontendServerState { /// /// [] /// [] +/// ``` class HotReloadFrontendServerController { final List frontendServerArgs; diff --git a/pkg/telemetry/lib/src/pii_regexp.dart b/pkg/telemetry/lib/src/pii_regexp.dart index 42846960854..7c189455cd6 100644 --- a/pkg/telemetry/lib/src/pii_regexp.dart +++ b/pkg/telemetry/lib/src/pii_regexp.dart @@ -31,7 +31,7 @@ class _RegExpList { } /// An ordered list of regular expressions to be substituted out and replaced -/// with a generic '' string. To be applied in sequence. +/// with a generic `` string. To be applied in sequence. /// The regular expressions here intentionally eat all characters after a /// path is identified, with the hope of catching all potential complex /// pathnames and assuming that most error messages will have any paths last. @@ -54,7 +54,7 @@ final _piiPathRegexps = _RegExpList([ ], ''); /// An ordered list of regular expressions to be substituted out and replaced -/// with a generic '' string. To be applied after +/// with a generic `` string. To be applied after /// all paths from [_piiPathRegexps] are applied. This is somewhat less /// all-encompassing than the path finder, above, just to try and grab things /// that could be file names but without being quite so greedy or depending diff --git a/pkg/vm/lib/modular/specializer/map_factory_specializer.dart b/pkg/vm/lib/modular/specializer/map_factory_specializer.dart index 297f2c4d917..f82816d21c2 100644 --- a/pkg/vm/lib/modular/specializer/map_factory_specializer.dart +++ b/pkg/vm/lib/modular/specializer/map_factory_specializer.dart @@ -7,9 +7,10 @@ import 'package:kernel/core_types.dart'; import 'factory_specializer.dart'; -/// Replaces invocation of Map factory constructors with -/// factories of VM-specific classes. -/// new LinkedHashMap() => new _Map() +/// Replaces invocation of Map factory constructors with factories of +/// VM-specific classes. +/// +/// new LinkedHashMap() => new _Map() class MapFactorySpecializer extends BaseSpecializer { final Procedure _linkedHashMapDefaultFactory; final Constructor _internalLinkedHashMapConstructor; diff --git a/pkg/vm/lib/modular/specializer/set_factory_specializer.dart b/pkg/vm/lib/modular/specializer/set_factory_specializer.dart index 05b661a8401..69b53085e79 100644 --- a/pkg/vm/lib/modular/specializer/set_factory_specializer.dart +++ b/pkg/vm/lib/modular/specializer/set_factory_specializer.dart @@ -8,9 +8,10 @@ import 'package:kernel/core_types.dart'; import 'factory_specializer.dart'; -/// Replaces invocation of Set factory constructors with -/// factories of VM-specific classes. -/// new LinkedHashSet() => new _Set() +/// Replaces invocation of Set factory constructors with factories of +/// VM-specific classes. +/// +/// new LinkedHashSet() => new _Set() class SetFactorySpecializer extends BaseSpecializer { final Procedure _linkedHashSetDefaultFactory; final Constructor _internalLinkedHashSetConstructor; diff --git a/pkg/vm/lib/modular/transformations/ffi/common.dart b/pkg/vm/lib/modular/transformations/ffi/common.dart index 674ab590386..8c6c519d0a1 100644 --- a/pkg/vm/lib/modular/transformations/ffi/common.dart +++ b/pkg/vm/lib/modular/transformations/ffi/common.dart @@ -689,6 +689,7 @@ class FfiTransformer extends Transformer { /// Computes the Dart type corresponding to a ffi.[NativeType], returns null /// if it is not a valid NativeType. /// + /// ``` /// [Int8] -> [int] /// [Int16] -> [int] /// [Int32] -> [int] @@ -709,6 +710,7 @@ class FfiTransformer extends Transformer { /// [Handle] -> [Object] /// [NativeFunction] S1 Function(S2, S3) /// where DartRepresentationOf(Tn) -> Sn + /// ``` DartType? convertNativeTypeToDartType( DartType nativeType, { bool allowStructAndUnion = false, diff --git a/pkg/vm/lib/modular/transformations/ffi/definitions.dart b/pkg/vm/lib/modular/transformations/ffi/definitions.dart index 82ca678b58d..3d532e2965a 100644 --- a/pkg/vm/lib/modular/transformations/ffi/definitions.dart +++ b/pkg/vm/lib/modular/transformations/ffi/definitions.dart @@ -36,6 +36,8 @@ import 'native_type_cfe.dart'; /// Checks and elaborates the dart:ffi compounds and their fields. /// /// Input: +/// +/// ``` /// final class Coord extends Struct { /// @Double() /// double x; @@ -45,8 +47,11 @@ import 'native_type_cfe.dart'; /// /// Pointer next; /// } +/// ``` /// /// Output: +/// +/// ``` /// final class Coord extends Struct { /// Coord.#fromTypedDataBase(Pointer coord) : super._(coord); /// @@ -61,6 +66,7 @@ import 'native_type_cfe.dart'; /// /// static int get #sizeOf => (const [24, 20, 24])[_abi()]; /// } +/// ``` void transformLibraries( Component component, CoreTypes coreTypes, diff --git a/pkg/vm/lib/modular/transformations/ffi/native_type_cfe.dart b/pkg/vm/lib/modular/transformations/ffi/native_type_cfe.dart index 4ecc000fe16..272352cb65b 100644 --- a/pkg/vm/lib/modular/transformations/ffi/native_type_cfe.dart +++ b/pkg/vm/lib/modular/transformations/ffi/native_type_cfe.dart @@ -142,8 +142,9 @@ sealed class NativeTypeCfe { /// the type will be loaded from that buffer, starting at [offsetInBytes]. /// /// For example, loading a `Pointer` from memory (via [PointerNativeTypeCfe]) - /// would build an expression like `ffi._loadPointer - /// (#typedDataBase, #offsetInBytes)`, where `Pointer == dartType`. + /// would build an expression like + /// `ffi._loadPointer(#typedDataBase, #offsetInBytes)`, where + /// `Pointer == dartType`. /// /// For struct fields, [generateGetterStatement] fills in values for /// [offsetInBytes] and [unaligned] based on the ABI of the struct. It also diff --git a/third_party/pkg/language_server_protocol/analysis_options.yaml b/third_party/pkg/language_server_protocol/analysis_options.yaml index 572dd239d09..8477c1bfcbd 100644 --- a/third_party/pkg/language_server_protocol/analysis_options.yaml +++ b/third_party/pkg/language_server_protocol/analysis_options.yaml @@ -1 +1,6 @@ include: package:lints/recommended.yaml + +analyzer: + errors: + # Existing violations (1) + unintended_html_in_doc_comment: ignore diff --git a/tools/addlatexhash.dart b/tools/addlatexhash.dart index 70d7e7dd3e8..bde5ae30451 100755 --- a/tools/addlatexhash.dart +++ b/tools/addlatexhash.dart @@ -488,12 +488,11 @@ String computeHashString( List lines, int startIndex, int nextIndex, IOSink listSink) => hex.encode(computeHashValue(lines, startIndex, nextIndex, listSink)); -/// Computes and adds hashes to \LMHash{} lines in [lines] (which -/// must be on the line numbers specified in [hashEvents]), and emits -/// sectioning markers and hash values to [listSink], along with -/// "comments" containing the simplified text (using the format -/// ' % ', where the text is one, long line, for easy grepping -/// etc.). +/// Computes and adds hashes to \LMHash{} lines in [lines] (which must be on the +/// line numbers specified in [hashEvents]), and emits sectioning markers and +/// hash values to [listSink], along with "comments" containing the simplified +/// text (using the format `' % '`, where the text is one, long line, for +/// easy grepping etc.). void addHashMarks( List lines, List hashEvents, IOSink listSink) { for (var hashEvent in hashEvents) { diff --git a/tools/manage_deps.dart b/tools/manage_deps.dart index 20e7a53649d..699bb169eb9 100755 --- a/tools/manage_deps.dart +++ b/tools/manage_deps.dart @@ -6,7 +6,11 @@ /// Helps rolling dependency to the newest version available /// (or a target version). /// -/// Usage: ./tools/manage_deps.dart bump [--branch ] [--target ] +/// Usage: +/// +/// ```bash +/// ./tools/manage_deps.dart bump [--branch ] [--target ] +/// ``` /// /// This will: /// 0. Check that git is clean