diff --git a/runtime/observatory/lib/elements.dart b/runtime/observatory/lib/elements.dart index 80f325c3c89..9d904032da0 100644 --- a/runtime/observatory/lib/elements.dart +++ b/runtime/observatory/lib/elements.dart @@ -92,7 +92,6 @@ export 'package:observatory/src/elements/type_arguments_ref.dart'; export 'package:observatory/src/elements/unknown_ref.dart'; export 'package:observatory/src/elements/unlinkedcall_ref.dart'; export 'package:observatory/src/elements/unlinkedcall_view.dart'; -export 'package:observatory/src/elements/view_footer.dart'; export 'package:observatory/src/elements/vm_connect.dart'; export 'package:observatory/src/elements/vm_connect_target.dart'; export 'package:observatory/src/elements/vm_view.dart'; diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart index 6ac2e066a36..27c8cb0eb47 100644 --- a/runtime/observatory/lib/src/elements/class_view.dart +++ b/runtime/observatory/lib/src/elements/class_view.dart @@ -30,7 +30,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/source_inset.dart'; import 'package:observatory/src/elements/source_link.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ClassViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -257,8 +256,6 @@ class ClassViewElement extends CustomElement implements Renderable { .element ] : const [], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/context_view.dart b/runtime/observatory/lib/src/elements/context_view.dart index 8cfb76c5e6b..bb72e983a23 100644 --- a/runtime/observatory/lib/src/elements/context_view.dart +++ b/runtime/observatory/lib/src/elements/context_view.dart @@ -19,7 +19,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ContextViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -187,9 +186,6 @@ class ContextViewElement extends CustomElement implements Renderable { ] ]); } - content.add(new DivElement() - ..classes = ['content-centered-big'] - ..children = [new ViewFooterElement(queue: _r.queue).element]); children = content; } } diff --git a/runtime/observatory/lib/src/elements/error_view.dart b/runtime/observatory/lib/src/elements/error_view.dart index 893e865414c..683c0a4902d 100644 --- a/runtime/observatory/lib/src/elements/error_view.dart +++ b/runtime/observatory/lib/src/elements/error_view.dart @@ -12,7 +12,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory/src/elements/helpers/custom_element.dart'; import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ErrorViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -67,7 +66,6 @@ class ErrorViewElement extends CustomElement implements Renderable { ..classes = ['well'] ..children = [new PreElement()..text = error.message] ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory/lib/src/elements/field_view.dart b/runtime/observatory/lib/src/elements/field_view.dart index 2844b8fd9ef..1827ccb41db 100644 --- a/runtime/observatory/lib/src/elements/field_view.dart +++ b/runtime/observatory/lib/src/elements/field_view.dart @@ -24,7 +24,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/script_inset.dart'; import 'package:observatory/src/elements/source_link.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class FieldViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -162,7 +161,6 @@ class FieldViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/flag_list.dart b/runtime/observatory/lib/src/elements/flag_list.dart index d01b782a96b..e7dfc4299b8 100644 --- a/runtime/observatory/lib/src/elements/flag_list.dart +++ b/runtime/observatory/lib/src/elements/flag_list.dart @@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class FlagListElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -108,7 +107,6 @@ class FlagListElement extends CustomElement implements Renderable { new DivElement() ..classes = ['content-centered'] ..children = content, - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory/lib/src/elements/function_view.dart b/runtime/observatory/lib/src/elements/function_view.dart index f4ecbfc457b..f8b44430ace 100644 --- a/runtime/observatory/lib/src/elements/function_view.dart +++ b/runtime/observatory/lib/src/elements/function_view.dart @@ -27,7 +27,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/source_inset.dart'; import 'package:observatory/src/elements/source_link.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class FunctionViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -145,7 +144,6 @@ class FunctionViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/icdata_view.dart b/runtime/observatory/lib/src/elements/icdata_view.dart index 90a0a3e7429..986e637328c 100644 --- a/runtime/observatory/lib/src/elements/icdata_view.dart +++ b/runtime/observatory/lib/src/elements/icdata_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ICDataViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -182,7 +181,6 @@ class ICDataViewElement extends CustomElement implements Renderable { ] ], new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/instance_view.dart b/runtime/observatory/lib/src/elements/instance_view.dart index ca36d455ae5..2063c281800 100644 --- a/runtime/observatory/lib/src/elements/instance_view.dart +++ b/runtime/observatory/lib/src/elements/instance_view.dart @@ -29,7 +29,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/source_inset.dart'; import 'package:observatory/src/elements/source_link.dart'; -import 'package:observatory/src/elements/view_footer.dart'; import 'package:observatory/utils.dart'; class InstanceViewElement extends CustomElement implements Renderable { @@ -163,8 +162,6 @@ class InstanceViewElement extends CustomElement implements Renderable { .element ]); } - content.addAll( - [new HRElement(), new ViewFooterElement(queue: _r.queue).element]); children = [ navBar(_createMenu()), new DivElement() diff --git a/runtime/observatory/lib/src/elements/isolate_reconnect.dart b/runtime/observatory/lib/src/elements/isolate_reconnect.dart index c6a02f91166..16f8eed74b8 100644 --- a/runtime/observatory/lib/src/elements/isolate_reconnect.dart +++ b/runtime/observatory/lib/src/elements/isolate_reconnect.dart @@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/custom_element.dart'; import 'package:observatory/src/elements/helpers/uris.dart'; import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class IsolateReconnectElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -104,7 +103,6 @@ class IsolateReconnectElement extends CustomElement implements Renderable { new AnchorElement(href: Uris.vm())..text = 'isolates summary', ])) ], - new ViewFooterElement(queue: _r.queue).element ]; } } diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart index d792d035d6c..bd6006400c9 100644 --- a/runtime/observatory/lib/src/elements/isolate_view.dart +++ b/runtime/observatory/lib/src/elements/isolate_view.dart @@ -27,7 +27,6 @@ import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/script_inset.dart'; import 'package:observatory/src/elements/source_inset.dart'; -import 'package:observatory/src/elements/view_footer.dart'; import 'package:observatory/utils.dart'; class IsolateViewElement extends CustomElement implements Renderable { @@ -305,8 +304,6 @@ class IsolateViewElement extends CustomElement implements Renderable { .element ] : const [], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/json_view.dart b/runtime/observatory/lib/src/elements/json_view.dart index 9e592780cad..fd406b86917 100644 --- a/runtime/observatory/lib/src/elements/json_view.dart +++ b/runtime/observatory/lib/src/elements/json_view.dart @@ -12,7 +12,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory/src/elements/helpers/custom_element.dart'; import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class JSONViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -63,8 +62,6 @@ class JSONViewElement extends CustomElement implements Renderable { new HeadingElement.h2()..text = 'Object', new HRElement(), new PreElement()..text = JSONPretty.stringify(_map), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/library_view.dart b/runtime/observatory/lib/src/elements/library_view.dart index 849eabadfd2..8ac928e431e 100644 --- a/runtime/observatory/lib/src/elements/library_view.dart +++ b/runtime/observatory/lib/src/elements/library_view.dart @@ -26,7 +26,6 @@ import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/script_ref.dart'; import 'package:observatory/src/elements/script_inset.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class LibraryViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -190,8 +189,6 @@ class LibraryViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/logging.dart b/runtime/observatory/lib/src/elements/logging.dart index 349401de211..af7d201bb34 100644 --- a/runtime/observatory/lib/src/elements/logging.dart +++ b/runtime/observatory/lib/src/elements/logging.dart @@ -19,7 +19,6 @@ import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class LoggingPageElement extends CustomElement implements Renderable { late RenderingScheduler _r; diff --git a/runtime/observatory/lib/src/elements/megamorphiccache_view.dart b/runtime/observatory/lib/src/elements/megamorphiccache_view.dart index fab2513483c..6bf2674f909 100644 --- a/runtime/observatory/lib/src/elements/megamorphiccache_view.dart +++ b/runtime/observatory/lib/src/elements/megamorphiccache_view.dart @@ -20,7 +20,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class MegamorphicCacheViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -177,8 +176,6 @@ class MegamorphicCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/object_view.dart b/runtime/observatory/lib/src/elements/object_view.dart index 7ff77083b91..c9f6ccad35c 100644 --- a/runtime/observatory/lib/src/elements/object_view.dart +++ b/runtime/observatory/lib/src/elements/object_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ObjectViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -116,8 +115,6 @@ class ObjectViewElement extends CustomElement implements Renderable { _reachableSizes, _references, _retainingPaths, _objects, queue: _r.queue) .element, - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/objectpool_view.dart b/runtime/observatory/lib/src/elements/objectpool_view.dart index 19673241015..4a07333177b 100644 --- a/runtime/observatory/lib/src/elements/objectpool_view.dart +++ b/runtime/observatory/lib/src/elements/objectpool_view.dart @@ -20,7 +20,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ObjectPoolViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -140,8 +139,6 @@ class ObjectPoolViewElement extends CustomElement implements Renderable { ..children = _createEntry(entry) ]) .toList(), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/objectstore_view.dart b/runtime/observatory/lib/src/elements/objectstore_view.dart index 59c400376f9..d040f7f9df7 100644 --- a/runtime/observatory/lib/src/elements/objectstore_view.dart +++ b/runtime/observatory/lib/src/elements/objectstore_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ObjectStoreViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -116,7 +115,6 @@ class ObjectStoreViewElement extends CustomElement implements Renderable { ] ]) .toList()), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/ports.dart b/runtime/observatory/lib/src/elements/ports.dart index 4a40a89e8a1..3a26377a3f3 100644 --- a/runtime/observatory/lib/src/elements/ports.dart +++ b/runtime/observatory/lib/src/elements/ports.dart @@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class PortsElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -101,7 +100,6 @@ class PortsElement extends CustomElement implements Renderable { new BRElement(), new DivElement()..children = _createList(), ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory/lib/src/elements/script_view.dart b/runtime/observatory/lib/src/elements/script_view.dart index 44fb84e2c71..bbffe71a1f0 100644 --- a/runtime/observatory/lib/src/elements/script_view.dart +++ b/runtime/observatory/lib/src/elements/script_view.dart @@ -21,7 +21,6 @@ import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; import 'package:observatory/src/elements/script_inset.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class ScriptViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -149,7 +148,6 @@ class ScriptViewElement extends CustomElement implements Renderable { new ScriptInsetElement(_isolate, _script, _scripts, _objects, _events, currentPos: _pos, queue: _r.queue) .element, - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/sentinel_view.dart b/runtime/observatory/lib/src/elements/sentinel_view.dart index dd45ef594a3..83082fbe9bf 100644 --- a/runtime/observatory/lib/src/elements/sentinel_view.dart +++ b/runtime/observatory/lib/src/elements/sentinel_view.dart @@ -13,7 +13,6 @@ import 'package:observatory/src/elements/nav/isolate_menu.dart'; import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class SentinelViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -82,8 +81,6 @@ class SentinelViewElement extends CustomElement implements Renderable { ..text = 'Sentinel: #{_sentinel.valueAsString}', new HRElement(), new DivElement()..text = _sentinelKindToDescription(_sentinel.kind), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/singletargetcache_view.dart b/runtime/observatory/lib/src/elements/singletargetcache_view.dart index 6d0fdd35bf7..66ad9392290 100644 --- a/runtime/observatory/lib/src/elements/singletargetcache_view.dart +++ b/runtime/observatory/lib/src/elements/singletargetcache_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class SingleTargetCacheViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -170,8 +169,6 @@ class SingleTargetCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/subtypetestcache_view.dart b/runtime/observatory/lib/src/elements/subtypetestcache_view.dart index 5734b7dc81a..2e3c6cf3a65 100644 --- a/runtime/observatory/lib/src/elements/subtypetestcache_view.dart +++ b/runtime/observatory/lib/src/elements/subtypetestcache_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class SubtypeTestCacheViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -141,8 +140,6 @@ class SubtypeTestCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/unlinkedcall_view.dart b/runtime/observatory/lib/src/elements/unlinkedcall_view.dart index a346b488182..d1efd9f3b3e 100644 --- a/runtime/observatory/lib/src/elements/unlinkedcall_view.dart +++ b/runtime/observatory/lib/src/elements/unlinkedcall_view.dart @@ -17,7 +17,6 @@ import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; import 'package:observatory/src/elements/object_common.dart'; -import 'package:observatory/src/elements/view_footer.dart'; class UnlinkedCallViewElement extends CustomElement implements Renderable { late RenderingScheduler _r; @@ -153,8 +152,6 @@ class UnlinkedCallViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory/lib/src/elements/view_footer.dart b/runtime/observatory/lib/src/elements/view_footer.dart deleted file mode 100644 index 1c8505b14f5..00000000000 --- a/runtime/observatory/lib/src/elements/view_footer.dart +++ /dev/null @@ -1,51 +0,0 @@ -// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file -// for details. All rights reserved. Use of this source code is governed by a -// BSD-style license that can be found in the LICENSE file. - -library view_footer_element; - -import 'dart:html'; -import 'dart:async'; -import 'package:observatory/src/elements/helpers/custom_element.dart'; -import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; - -class ViewFooterElement extends CustomElement implements Renderable { - late RenderingScheduler _r; - - Stream> get onRendered => _r.onRendered; - - factory ViewFooterElement({RenderingQueue? queue}) { - ViewFooterElement e = new ViewFooterElement.created(); - e._r = new RenderingScheduler(e, queue: queue); - return e; - } - - ViewFooterElement.created() : super.created('view-footer'); - - @override - void attached() { - super.attached(); - _r.enable(); - } - - @override - void detached() { - super.detached(); - children = []; - _r.disable(notify: true); - } - - void render() { - children = [ - new AnchorElement() - // ignore: unsafe_html - ..href = 'https://dart-lang.github.io/observatory/' - ..text = 'View documentation', - new AnchorElement() - // ignore: unsafe_html - ..href = - 'https://github.com/dart-lang/sdk/issues/new?title=Observatory:&body=Observatory%20Feedback' - ..text = 'File a bug report' - ]; - } -} diff --git a/runtime/observatory/lib/src/elements/vm_connect.dart b/runtime/observatory/lib/src/elements/vm_connect.dart index 26bfb17ba51..c90c7ab0d82 100644 --- a/runtime/observatory/lib/src/elements/vm_connect.dart +++ b/runtime/observatory/lib/src/elements/vm_connect.dart @@ -13,7 +13,6 @@ import 'package:observatory/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory/src/elements/helpers/custom_element.dart'; import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; import 'package:observatory/src/elements/vm_connect_target.dart'; class VMConnectElement extends CustomElement implements Renderable { @@ -114,7 +113,6 @@ class VMConnectElement extends CustomElement implements Renderable { new DivElement()..classes = ['flex-item-20-percent'], ], ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory/lib/src/elements/vm_view.dart b/runtime/observatory/lib/src/elements/vm_view.dart index 4bcec55ace1..80c29107d00 100644 --- a/runtime/observatory/lib/src/elements/vm_view.dart +++ b/runtime/observatory/lib/src/elements/vm_view.dart @@ -16,7 +16,6 @@ import 'package:observatory/src/elements/nav/notify.dart'; import 'package:observatory/src/elements/nav/refresh.dart'; import 'package:observatory/src/elements/nav/top_menu.dart'; import 'package:observatory/src/elements/nav/vm_menu.dart'; -import 'package:observatory/src/elements/view_footer.dart'; import 'package:observatory/utils.dart'; class VMViewElement extends CustomElement implements Renderable { @@ -119,7 +118,6 @@ class VMViewElement extends CustomElement implements Renderable { describeVM(), describeIsolateGroups(), describeSystemIsolateGroups(), - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory/observatory_sources.gni b/runtime/observatory/observatory_sources.gni index 88db18ef04f..8ea8e7c176b 100644 --- a/runtime/observatory/observatory_sources.gni +++ b/runtime/observatory/observatory_sources.gni @@ -137,7 +137,6 @@ observatory_sources = [ "lib/src/elements/unknown_ref.dart", "lib/src/elements/unlinkedcall_ref.dart", "lib/src/elements/unlinkedcall_view.dart", - "lib/src/elements/view_footer.dart", "lib/src/elements/vm_connect.dart", "lib/src/elements/vm_connect_target.dart", "lib/src/elements/vm_view.dart", diff --git a/runtime/observatory_2/lib/elements.dart b/runtime/observatory_2/lib/elements.dart index b4f60b728b2..9f18b1c67f0 100644 --- a/runtime/observatory_2/lib/elements.dart +++ b/runtime/observatory_2/lib/elements.dart @@ -93,7 +93,6 @@ export 'package:observatory_2/src/elements/type_arguments_ref.dart'; export 'package:observatory_2/src/elements/unknown_ref.dart'; export 'package:observatory_2/src/elements/unlinkedcall_ref.dart'; export 'package:observatory_2/src/elements/unlinkedcall_view.dart'; -export 'package:observatory_2/src/elements/view_footer.dart'; export 'package:observatory_2/src/elements/vm_connect.dart'; export 'package:observatory_2/src/elements/vm_connect_target.dart'; export 'package:observatory_2/src/elements/vm_view.dart'; diff --git a/runtime/observatory_2/lib/src/elements/class_view.dart b/runtime/observatory_2/lib/src/elements/class_view.dart index 4dd190e60fe..188514c8f74 100644 --- a/runtime/observatory_2/lib/src/elements/class_view.dart +++ b/runtime/observatory_2/lib/src/elements/class_view.dart @@ -30,7 +30,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/source_inset.dart'; import 'package:observatory_2/src/elements/source_link.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ClassViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -257,8 +256,6 @@ class ClassViewElement extends CustomElement implements Renderable { .element ] : const [], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/context_view.dart b/runtime/observatory_2/lib/src/elements/context_view.dart index 3b759eb6ded..27030ecbfe9 100644 --- a/runtime/observatory_2/lib/src/elements/context_view.dart +++ b/runtime/observatory_2/lib/src/elements/context_view.dart @@ -19,7 +19,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ContextViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -187,9 +186,6 @@ class ContextViewElement extends CustomElement implements Renderable { ] ]); } - content.add(new DivElement() - ..classes = ['content-centered-big'] - ..children = [new ViewFooterElement(queue: _r.queue).element]); children = content; } } diff --git a/runtime/observatory_2/lib/src/elements/error_view.dart b/runtime/observatory_2/lib/src/elements/error_view.dart index d4edfb23c20..2d7393eb38d 100644 --- a/runtime/observatory_2/lib/src/elements/error_view.dart +++ b/runtime/observatory_2/lib/src/elements/error_view.dart @@ -12,7 +12,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory_2/src/elements/helpers/custom_element.dart'; import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ErrorViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -67,7 +66,6 @@ class ErrorViewElement extends CustomElement implements Renderable { ..classes = ['well'] ..children = [new PreElement()..text = error.message] ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory_2/lib/src/elements/field_view.dart b/runtime/observatory_2/lib/src/elements/field_view.dart index 5e4979ff374..50c9c17ca59 100644 --- a/runtime/observatory_2/lib/src/elements/field_view.dart +++ b/runtime/observatory_2/lib/src/elements/field_view.dart @@ -24,7 +24,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/script_inset.dart'; import 'package:observatory_2/src/elements/source_link.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class FieldViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -162,7 +161,6 @@ class FieldViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/flag_list.dart b/runtime/observatory_2/lib/src/elements/flag_list.dart index 5f540fcdd26..be6f86392e9 100644 --- a/runtime/observatory_2/lib/src/elements/flag_list.dart +++ b/runtime/observatory_2/lib/src/elements/flag_list.dart @@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class FlagListElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -108,7 +107,6 @@ class FlagListElement extends CustomElement implements Renderable { new DivElement() ..classes = ['content-centered'] ..children = content, - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory_2/lib/src/elements/function_view.dart b/runtime/observatory_2/lib/src/elements/function_view.dart index 963ecc41234..9850fde1579 100644 --- a/runtime/observatory_2/lib/src/elements/function_view.dart +++ b/runtime/observatory_2/lib/src/elements/function_view.dart @@ -27,7 +27,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/source_inset.dart'; import 'package:observatory_2/src/elements/source_link.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class FunctionViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -145,7 +144,6 @@ class FunctionViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/icdata_view.dart b/runtime/observatory_2/lib/src/elements/icdata_view.dart index 80188975b0a..e52c5a4d3ee 100644 --- a/runtime/observatory_2/lib/src/elements/icdata_view.dart +++ b/runtime/observatory_2/lib/src/elements/icdata_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ICDataViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -181,8 +180,6 @@ class ICDataViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/instance_view.dart b/runtime/observatory_2/lib/src/elements/instance_view.dart index 1b78e7dfd4d..fcc18125c78 100644 --- a/runtime/observatory_2/lib/src/elements/instance_view.dart +++ b/runtime/observatory_2/lib/src/elements/instance_view.dart @@ -29,7 +29,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/source_inset.dart'; import 'package:observatory_2/src/elements/source_link.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; import 'package:observatory_2/utils.dart'; class InstanceViewElement extends CustomElement implements Renderable { @@ -162,8 +161,6 @@ class InstanceViewElement extends CustomElement implements Renderable { .element ]); } - content.addAll( - [new HRElement(), new ViewFooterElement(queue: _r.queue).element]); children = [ navBar(_createMenu()), new DivElement() diff --git a/runtime/observatory_2/lib/src/elements/isolate_reconnect.dart b/runtime/observatory_2/lib/src/elements/isolate_reconnect.dart index f4b9e2384ea..6beb606b566 100644 --- a/runtime/observatory_2/lib/src/elements/isolate_reconnect.dart +++ b/runtime/observatory_2/lib/src/elements/isolate_reconnect.dart @@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/helpers/custom_element.dart'; import 'package:observatory_2/src/elements/helpers/uris.dart'; import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class IsolateReconnectElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -104,7 +103,6 @@ class IsolateReconnectElement extends CustomElement implements Renderable { new AnchorElement(href: Uris.vm())..text = 'isolates summary', ])) ], - new ViewFooterElement(queue: _r.queue).element ]; } } diff --git a/runtime/observatory_2/lib/src/elements/isolate_view.dart b/runtime/observatory_2/lib/src/elements/isolate_view.dart index 59104c9e03e..08f281ea977 100644 --- a/runtime/observatory_2/lib/src/elements/isolate_view.dart +++ b/runtime/observatory_2/lib/src/elements/isolate_view.dart @@ -27,7 +27,6 @@ import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/script_inset.dart'; import 'package:observatory_2/src/elements/source_inset.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; import 'package:observatory_2/utils.dart'; class IsolateViewElement extends CustomElement implements Renderable { @@ -305,8 +304,6 @@ class IsolateViewElement extends CustomElement implements Renderable { .element ] : const [], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/json_view.dart b/runtime/observatory_2/lib/src/elements/json_view.dart index f003d60aadd..b3cf6f225c6 100644 --- a/runtime/observatory_2/lib/src/elements/json_view.dart +++ b/runtime/observatory_2/lib/src/elements/json_view.dart @@ -12,7 +12,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory_2/src/elements/helpers/custom_element.dart'; import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class JSONViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -63,8 +62,6 @@ class JSONViewElement extends CustomElement implements Renderable { new HeadingElement.h2()..text = 'Object', new HRElement(), new PreElement()..text = JSONPretty.stringify(_map), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/library_view.dart b/runtime/observatory_2/lib/src/elements/library_view.dart index b1c96568c15..6487337fd91 100644 --- a/runtime/observatory_2/lib/src/elements/library_view.dart +++ b/runtime/observatory_2/lib/src/elements/library_view.dart @@ -26,7 +26,6 @@ import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/script_ref.dart'; import 'package:observatory_2/src/elements/script_inset.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class LibraryViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -190,8 +189,6 @@ class LibraryViewElement extends CustomElement implements Renderable { queue: _r.queue) .element ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/logging.dart b/runtime/observatory_2/lib/src/elements/logging.dart index dd922a219fe..66734919f5c 100644 --- a/runtime/observatory_2/lib/src/elements/logging.dart +++ b/runtime/observatory_2/lib/src/elements/logging.dart @@ -19,7 +19,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class LoggingPageElement extends CustomElement implements Renderable { RenderingScheduler _r; diff --git a/runtime/observatory_2/lib/src/elements/megamorphiccache_view.dart b/runtime/observatory_2/lib/src/elements/megamorphiccache_view.dart index 71bb435d352..95f3aba27b2 100644 --- a/runtime/observatory_2/lib/src/elements/megamorphiccache_view.dart +++ b/runtime/observatory_2/lib/src/elements/megamorphiccache_view.dart @@ -20,7 +20,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class MegamorphicCacheViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -177,8 +176,6 @@ class MegamorphicCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/object_view.dart b/runtime/observatory_2/lib/src/elements/object_view.dart index ee41d783994..6a6f01c0a59 100644 --- a/runtime/observatory_2/lib/src/elements/object_view.dart +++ b/runtime/observatory_2/lib/src/elements/object_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ObjectViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -117,8 +116,6 @@ class ObjectViewElement extends CustomElement implements Renderable { _reachableSizes, _references, _retainingPaths, _objects, queue: _r.queue) .element, - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/objectpool_view.dart b/runtime/observatory_2/lib/src/elements/objectpool_view.dart index a99091a1320..fa746517267 100644 --- a/runtime/observatory_2/lib/src/elements/objectpool_view.dart +++ b/runtime/observatory_2/lib/src/elements/objectpool_view.dart @@ -20,7 +20,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ObjectPoolViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -140,8 +139,6 @@ class ObjectPoolViewElement extends CustomElement implements Renderable { ..children = _createEntry(entry) ]) .toList(), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/objectstore_view.dart b/runtime/observatory_2/lib/src/elements/objectstore_view.dart index 864ca5952c8..1c6cdb914c0 100644 --- a/runtime/observatory_2/lib/src/elements/objectstore_view.dart +++ b/runtime/observatory_2/lib/src/elements/objectstore_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ObjectStoreViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -116,7 +115,6 @@ class ObjectStoreViewElement extends CustomElement implements Renderable { ] ]) .toList()), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/ports.dart b/runtime/observatory_2/lib/src/elements/ports.dart index e8e4a49e005..3d44346eb7a 100644 --- a/runtime/observatory_2/lib/src/elements/ports.dart +++ b/runtime/observatory_2/lib/src/elements/ports.dart @@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class PortsElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -101,7 +100,6 @@ class PortsElement extends CustomElement implements Renderable { new BRElement(), new DivElement()..children = _createList(), ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory_2/lib/src/elements/script_view.dart b/runtime/observatory_2/lib/src/elements/script_view.dart index 349aabc6324..e90c1b63c20 100644 --- a/runtime/observatory_2/lib/src/elements/script_view.dart +++ b/runtime/observatory_2/lib/src/elements/script_view.dart @@ -21,7 +21,6 @@ import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; import 'package:observatory_2/src/elements/script_inset.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class ScriptViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -149,7 +148,6 @@ class ScriptViewElement extends CustomElement implements Renderable { new ScriptInsetElement(_isolate, _script, _scripts, _objects, _events, currentPos: _pos, queue: _r.queue) .element, - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/sentinel_view.dart b/runtime/observatory_2/lib/src/elements/sentinel_view.dart index 5628e78b6ac..33fde815bbc 100644 --- a/runtime/observatory_2/lib/src/elements/sentinel_view.dart +++ b/runtime/observatory_2/lib/src/elements/sentinel_view.dart @@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/nav/isolate_menu.dart'; import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class SentinelViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -82,8 +81,6 @@ class SentinelViewElement extends CustomElement implements Renderable { ..text = 'Sentinel: #{_sentinel.valueAsString}', new HRElement(), new DivElement()..text = _sentinelKindToDescription(_sentinel.kind), - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/singletargetcache_view.dart b/runtime/observatory_2/lib/src/elements/singletargetcache_view.dart index b8d3224140d..8aabfa39350 100644 --- a/runtime/observatory_2/lib/src/elements/singletargetcache_view.dart +++ b/runtime/observatory_2/lib/src/elements/singletargetcache_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class SingleTargetCacheViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -170,8 +169,6 @@ class SingleTargetCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/subtypetestcache_view.dart b/runtime/observatory_2/lib/src/elements/subtypetestcache_view.dart index ba42732b423..37ff6b00b23 100644 --- a/runtime/observatory_2/lib/src/elements/subtypetestcache_view.dart +++ b/runtime/observatory_2/lib/src/elements/subtypetestcache_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class SubtypeTestCacheViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -141,8 +140,6 @@ class SubtypeTestCacheViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/unlinkedcall_view.dart b/runtime/observatory_2/lib/src/elements/unlinkedcall_view.dart index 76c29c0eec0..a84edf7594a 100644 --- a/runtime/observatory_2/lib/src/elements/unlinkedcall_view.dart +++ b/runtime/observatory_2/lib/src/elements/unlinkedcall_view.dart @@ -17,7 +17,6 @@ import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; import 'package:observatory_2/src/elements/object_common.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; class UnlinkedCallViewElement extends CustomElement implements Renderable { RenderingScheduler _r; @@ -153,8 +152,6 @@ class UnlinkedCallViewElement extends CustomElement implements Renderable { ] ] ], - new HRElement(), - new ViewFooterElement(queue: _r.queue).element ] ]; } diff --git a/runtime/observatory_2/lib/src/elements/view_footer.dart b/runtime/observatory_2/lib/src/elements/view_footer.dart deleted file mode 100644 index 2f0245189d1..00000000000 --- a/runtime/observatory_2/lib/src/elements/view_footer.dart +++ /dev/null @@ -1,51 +0,0 @@ -// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file -// for details. All rights reserved. Use of this source code is governed by a -// BSD-style license that can be found in the LICENSE file. - -library view_footer_element; - -import 'dart:html'; -import 'dart:async'; -import 'package:observatory_2/src/elements/helpers/custom_element.dart'; -import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart'; - -class ViewFooterElement extends CustomElement implements Renderable { - RenderingScheduler _r; - - Stream> get onRendered => _r.onRendered; - - factory ViewFooterElement({RenderingQueue queue}) { - ViewFooterElement e = new ViewFooterElement.created(); - e._r = new RenderingScheduler(e, queue: queue); - return e; - } - - ViewFooterElement.created() : super.created('view-footer'); - - @override - void attached() { - super.attached(); - _r.enable(); - } - - @override - void detached() { - super.detached(); - children = []; - _r.disable(notify: true); - } - - void render() { - children = [ - new AnchorElement() - // ignore: unsafe_html - ..href = 'https://dart-lang.github.io/observatory/' - ..text = 'View documentation', - new AnchorElement() - // ignore: unsafe_html - ..href = - 'https://github.com/dart-lang/sdk/issues/new?title=Observatory:&body=Observatory%20Feedback' - ..text = 'File a bug report' - ]; - } -} diff --git a/runtime/observatory_2/lib/src/elements/vm_connect.dart b/runtime/observatory_2/lib/src/elements/vm_connect.dart index fe30bc9b495..8cf099e7b5d 100644 --- a/runtime/observatory_2/lib/src/elements/vm_connect.dart +++ b/runtime/observatory_2/lib/src/elements/vm_connect.dart @@ -13,7 +13,6 @@ import 'package:observatory_2/src/elements/helpers/rendering_scheduler.dart'; import 'package:observatory_2/src/elements/helpers/custom_element.dart'; import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; import 'package:observatory_2/src/elements/vm_connect_target.dart'; class VMConnectElement extends CustomElement implements Renderable { @@ -114,7 +113,6 @@ class VMConnectElement extends CustomElement implements Renderable { new DivElement()..classes = ['flex-item-20-percent'], ], ], - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory_2/lib/src/elements/vm_view.dart b/runtime/observatory_2/lib/src/elements/vm_view.dart index b7b6d6571da..97d46728426 100644 --- a/runtime/observatory_2/lib/src/elements/vm_view.dart +++ b/runtime/observatory_2/lib/src/elements/vm_view.dart @@ -16,7 +16,6 @@ import 'package:observatory_2/src/elements/nav/notify.dart'; import 'package:observatory_2/src/elements/nav/refresh.dart'; import 'package:observatory_2/src/elements/nav/top_menu.dart'; import 'package:observatory_2/src/elements/nav/vm_menu.dart'; -import 'package:observatory_2/src/elements/view_footer.dart'; import 'package:observatory_2/utils.dart'; class VMViewElement extends CustomElement implements Renderable { @@ -119,7 +118,6 @@ class VMViewElement extends CustomElement implements Renderable { describeVM(), describeIsolateGroups(), describeSystemIsolateGroups(), - new ViewFooterElement(queue: _r.queue).element ]; } diff --git a/runtime/observatory_2/observatory_sources.gni b/runtime/observatory_2/observatory_sources.gni index 7bf2bbb618b..0ee61e2c885 100644 --- a/runtime/observatory_2/observatory_sources.gni +++ b/runtime/observatory_2/observatory_sources.gni @@ -139,7 +139,6 @@ observatory_sources = [ "lib/src/elements/unknown_ref.dart", "lib/src/elements/unlinkedcall_ref.dart", "lib/src/elements/unlinkedcall_view.dart", - "lib/src/elements/view_footer.dart", "lib/src/elements/vm_connect.dart", "lib/src/elements/vm_connect_target.dart", "lib/src/elements/vm_view.dart",