From 1b6201bfe58c49b2138d3548dfd8fbda037e7086 Mon Sep 17 00:00:00 2001 From: Konstantin Shcheglov Date: Fri, 29 May 2020 18:22:04 +0000 Subject: [PATCH] Update build_sdk_summaries to 'build' command, update help. Change-Id: I8aac5209fc0c7c481c9bf5ffb93faef183532572 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149482 Reviewed-by: Brian Wilkerson Commit-Queue: Konstantin Shcheglov --- .../tool/summary/build_sdk_summaries.dart | 23 +++++-------------- utils/dartanalyzer/BUILD.gn | 4 ++-- 2 files changed, 8 insertions(+), 19 deletions(-) diff --git a/pkg/analyzer/tool/summary/build_sdk_summaries.dart b/pkg/analyzer/tool/summary/build_sdk_summaries.dart index 4fa2b7e6e01..5c0590b98ec 100644 --- a/pkg/analyzer/tool/summary/build_sdk_summaries.dart +++ b/pkg/analyzer/tool/summary/build_sdk_summaries.dart @@ -7,7 +7,6 @@ import 'dart:io'; import 'package:analyzer/file_system/physical_file_system.dart'; import 'package:analyzer/src/dart/sdk/sdk.dart'; import 'package:analyzer/src/summary/summary_file_builder.dart'; -import 'package:meta/meta.dart'; void main(List args) { String command; @@ -41,12 +40,8 @@ void main(List args) { // // Handle commands. // - if (command == 'build-strong') { - _buildSummary( - sdkPath, - outFilePath, - title: 'legacy', - ); + if (command == 'build' || command == 'build-strong') { + _buildSummary(sdkPath, outFilePath); } else { _printUsage(); return; @@ -58,12 +53,8 @@ void main(List args) { */ const BINARY_NAME = "build_sdk_summaries"; -void _buildSummary( - String sdkPath, - String outPath, { - @required String title, -}) { - print('Generating $title summary.'); +void _buildSummary(String sdkPath, String outPath) { + print('Generating summary.'); Stopwatch sw = Stopwatch()..start(); List bytes = buildSdkSummary( resourceProvider: PhysicalResourceProvider.INSTANCE, @@ -79,8 +70,6 @@ void _buildSummary( void _printUsage() { print('Usage: $BINARY_NAME command arguments'); print('Where command can be one of the following:'); - print(' build-non-nullable output_file [sdk_path]'); - print(' Generate non-nullable summary file.'); - print(' build-legacy output_file [sdk_path]'); - print(' Generate legacy summary file.'); + print(' build output_file [sdk_path]'); + print(' Generate summary file.'); } diff --git a/utils/dartanalyzer/BUILD.gn b/utils/dartanalyzer/BUILD.gn index b262009bec7..59e462f126e 100644 --- a/utils/dartanalyzer/BUILD.gn +++ b/utils/dartanalyzer/BUILD.gn @@ -46,13 +46,13 @@ prebuilt_dart_action("generate_summary_strong") { outputs = [ output ] if (!dont_use_nnbd) { args = [ - "build-strong", + "build", rebase_path(output), rebase_path("../../sdk_nnbd"), ] } else { args = [ - "build-strong", + "build", rebase_path(output), rebase_path("../../sdk"), ]