From 09b97fefd4fca92a5feca82926bef2d174b93f06 Mon Sep 17 00:00:00 2001 From: "hausner@google.com" Date: Tue, 13 Mar 2012 21:07:42 +0000 Subject: [PATCH] Address Ivan's review comments. Review URL: https://chromiumcodereview.appspot.com//9696048 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5438 260f80e4-7a28-3924-810f-c04153c831b5 --- runtime/lib/date.cc | 1 - runtime/lib/isolate.cc | 1 + runtime/vm/native_entry.h | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/lib/date.cc b/runtime/lib/date.cc index 2570c987354..9a993428627 100644 --- a/runtime/lib/date.cc +++ b/runtime/lib/date.cc @@ -5,7 +5,6 @@ #include "vm/bootstrap_natives.h" #include "vm/bigint_operations.h" -#include "vm/exceptions.h" #include "vm/native_entry.h" #include "vm/object.h" #include "vm/os.h" diff --git a/runtime/lib/isolate.cc b/runtime/lib/isolate.cc index 926275c66eb..8f025e816a6 100644 --- a/runtime/lib/isolate.cc +++ b/runtime/lib/isolate.cc @@ -258,6 +258,7 @@ static char* BuildIsolateName(const char* script_name, DEFINE_NATIVE_ENTRY(IsolateNatives_start, 2) { Isolate* preserved_isolate = Isolate::Current(); GET_NATIVE_ARGUMENT(Instance, runnable, arguments->At(0)); + // arguments->At(1) unused. const Class& runnable_class = Class::Handle(runnable.clazz()); const char* class_name = String::Handle(runnable_class.Name()).ToCString(); const Library& library = Library::Handle(runnable_class.library()); diff --git a/runtime/vm/native_entry.h b/runtime/vm/native_entry.h index 1fe7aba1800..f2e9e682b48 100644 --- a/runtime/vm/native_entry.h +++ b/runtime/vm/native_entry.h @@ -7,6 +7,7 @@ #include "vm/allocation.h" #include "vm/assembler.h" +#include "vm/exceptions.h" #include "vm/native_arguments.h" #include "vm/verifier.h"