From 09456bfb6fbb015fc0909dfd4b5391de96a8b3e0 Mon Sep 17 00:00:00 2001 From: Zachary Anderson Date: Wed, 9 Aug 2017 10:03:49 -0700 Subject: [PATCH] [vm] Reset vm isolate symbol table load factor fixes #30371 R=rmacnak@google.com Review-Url: https://codereview.chromium.org/2999743002 . --- runtime/vm/symbols.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc index f4e0df36b38..668c4984a4d 100644 --- a/runtime/vm/symbols.cc +++ b/runtime/vm/symbols.cc @@ -336,9 +336,11 @@ RawArray* Symbols::UnifiedSymbolTable() { } table.Release(); - const double kMinLoad = 0.90; - const double kMaxLoad = 0.90; - HashTables::EnsureLoadFactor(kMinLoad, kMaxLoad, unified_table); + // TODO(30378): The default load factor of 0.75 / 2 burns ~100KB, but + // increasing the load factor regresses Flutter's hot restart time. + // const double kMinLoad = 0.90; + // const double kMaxLoad = 0.90; + // HashTables::EnsureLoadFactor(kMinLoad, kMaxLoad, unified_table); return unified_table.Release().raw(); }