From 08cff379ca2967029d8a5faaf372007ba5ff0ae7 Mon Sep 17 00:00:00 2001 From: "scheglov@google.com" Date: Thu, 26 Feb 2015 01:34:25 +0000 Subject: [PATCH] Don't propose 'Assign to local variable' when in arguments list. R=brianwilkerson@google.com BUG= Review URL: https://codereview.chromium.org//943053005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44036 260f80e4-7a28-3924-810f-c04153c831b5 --- .../lib/src/services/correction/assist_internal.dart | 5 +++++ .../test/services/correction/assist_test.dart | 10 ++++++++++ 2 files changed, 15 insertions(+) diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart index bb6726d1c2a..376e4140cb4 100644 --- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart +++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart @@ -362,6 +362,11 @@ class AssistProcessor { // prepare expression Expression expression = expressionStatement.expression; int offset = expression.offset; + // ignore if in arguments + if (node.getAncestor((node) => node is ArgumentList) != null) { + _coverageMarker(); + return; + } // ignore if already assignment if (expression is AssignmentExpression) { _coverageMarker(); diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart index 4c48713fa93..c40acb1348b 100644 --- a/pkg/analysis_server/test/services/correction/assist_test.dart +++ b/pkg/analysis_server/test/services/correction/assist_test.dart @@ -613,6 +613,16 @@ main() { assertNoAssistAt('vvv =', AssistKind.ASSIGN_TO_LOCAL_VARIABLE); } + void test_assignToLocalVariable_invocationArgument() { + resolveTestUnit(r''' +main() { + f(12345); +} +int f(p) {} +'''); + assertNoAssistAt('345', AssistKind.ASSIGN_TO_LOCAL_VARIABLE); + } + void test_assignToLocalVariable_throw() { resolveTestUnit(''' main() {