From 07da83d321bd9e4afc582fdaffd97161f686a09d Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Wed, 14 Aug 2024 10:00:49 +0000 Subject: [PATCH] [dart2wasm] Simplify source map flag code in `dart compile wasm` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After [0] lands we can remove a workaround in `dart compile wasm` that checks for `--extra-compiler-option=--no-source-maps`. [0] https://github.com/flutter/flutter/pull/153417 Change-Id: I19f4da96e198d73e2309652aa2aa08d5e2c72d48 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380461 Commit-Queue: Martin Kustermann Reviewed-by: Ömer Ağacan --- pkg/dartdev/lib/src/commands/compile.dart | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/pkg/dartdev/lib/src/commands/compile.dart b/pkg/dartdev/lib/src/commands/compile.dart index 6e6ff173538..61f91458ba9 100644 --- a/pkg/dartdev/lib/src/commands/compile.dart +++ b/pkg/dartdev/lib/src/commands/compile.dart @@ -809,13 +809,7 @@ class CompileWasmCommand extends CompileSubcommandCommand { handleOverride(optimizationFlags, 'minify', args.wasParsed('minify') ? args.flag('minify') : null); - bool generateSourceMap = args.flag('source-maps'); - // TODO(kustermann): Remive this temporary change when flutter no longer - // uses --extra-compiler-option=--no-source-maps - if (extraCompilerOptions.any((o) => o == '--no-source-maps')) { - generateSourceMap = false; - } - + final generateSourceMap = args.flag('source-maps'); final enabledExperiments = args.enabledExperiments; final dart2wasmCommand = [ sdk.dartAotRuntime,