[infra] Fail hard if starting RBE fails.
The build isn't going to go through anyway and the slow 3 minute default timeout is just confusing and annoying when this happens. There isn't any additional useful context being output like the comment suggested. Bug: b/331346866 Change-Id: I0475002469c372fefe3a54d104b54692c89ca9f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359800 Commit-Queue: Jonas Termansen <sortie@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
committed by
Commit Queue
parent
2b2c6ec267
commit
05936f4d0b
+2
-5
@@ -169,8 +169,7 @@ def StartRBE(out_dir, use_goma, env):
|
||||
process = subprocess.Popen(bootstrap_command, env=env)
|
||||
process.wait()
|
||||
if process.returncode != 0:
|
||||
print(f"Starting {rbe} failed. Try running it manually: " + "\n\t" +
|
||||
' '.join(bootstrap_command))
|
||||
print(f"Failed to start {rbe}")
|
||||
return False
|
||||
rbe_started = rbe
|
||||
return True
|
||||
@@ -201,9 +200,7 @@ def BuildOneConfig(options, targets, target_os, mode, arch, sanitizer, env):
|
||||
command += [('-j%s' % str(options.j))]
|
||||
command += [('-l%s' % str(options.l))]
|
||||
else:
|
||||
# If we couldn't ensure that RBE is started, let the build start,
|
||||
# but slowly so we can see any helpful error messages that pop out.
|
||||
command += ['-j1']
|
||||
exit(1)
|
||||
command += targets
|
||||
return (build_config, command, using_rbe)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user