dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Change a few language_2 tests to comply with reality

Browse Source 
Fix up override_inheritance_method_test.dart
Fix up override_inheritance_generic_test.dart
Fix up override_inheritance_field_test.dart
Fix up override_field_test.dart

Change-Id: I09f88c18e2473be645a955e1dc63d788e61382f4
Reviewed-on: https://dart-review.googlesource.com/64682
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
This commit is contained in:
Jens Johansen
2018-08-01 11:03:12 +00:00
committed by commit-bot@chromium.org
parent cf77a3b00f
commit 03df8b1eb8
8 changed files with 27 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/language_2/language_2_analyzer.status
+1 -8
View File
@@ -90,7 +90,7 @@ mock_writable_final_private_field_test: CompileTimeError # Issue 30848
nested_generic_closure_test: CompileTimeError
no_main_test/01: Fail # Issue 20030
no_such_constructor2_test: StaticWarning
override_field_test/03: Fail # Issue 29703
override_field_test/02: CompileTimeError
part_of_multiple_libs_test/01: MissingCompileTimeError # Issue 33227
part_refers_to_core_library_test/01: MissingCompileTimeError # Issue 29709
prefix_shadow_test/01: MissingCompileTimeError # Issue 33005
@@ -279,14 +279,7 @@ multiline_newline_test/05: MissingCompileTimeError
multiline_newline_test/05r: MissingCompileTimeError
multiple_interface_inheritance_test: CompileTimeError # Issue 30552
no_main_test/01: MissingStaticWarning # Issue 28823
override_inheritance_field_test/04: CompileTimeError
override_inheritance_field_test/06: CompileTimeError
override_inheritance_field_test/26: CompileTimeError
override_inheritance_field_test/29: CompileTimeError
override_inheritance_field_test/42: CompileTimeError
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
parser_quirks_test: CompileTimeError
regress_22976_test/01: CompileTimeError
regress_22976_test/02: CompileTimeError
tests/language_2/language_2_dart2js.status
-11
View File
@@ -638,8 +638,6 @@ mixin_super_bound_test/02: MissingCompileTimeError
mixin_type_parameters_errors_test/03: MissingCompileTimeError
mixin_type_parameters_errors_test/04: MissingCompileTimeError
named_constructor_test/01: MissingCompileTimeError
override_field_test/02: MissingCompileTimeError
override_field_test/03: MissingCompileTimeError
partial_tearoff_instantiation_test/05: Crash # Assertion failure: kind=special,memberName=instantiate,callStructure:CallStructure(arity=0, types=1)
partial_tearoff_instantiation_test/06: Crash # Assertion failure: kind=special,memberName=instantiate,callStructure:CallStructure(arity=0, types=1)
partial_tearoff_instantiation_test/07: Crash # Assertion failure: kind=special,memberName=instantiate,callStructure:CallStructure(arity=0, types=1)
@@ -794,8 +792,6 @@ named_constructor_test/01: MissingCompileTimeError
no_such_method_native_test: RuntimeError
no_such_method_test: RuntimeError
overridden_no_such_method_test: RuntimeError
override_field_test/02: MissingCompileTimeError
override_field_test/03: MissingCompileTimeError
recursive_generic_test: RuntimeError
redirecting_factory_infinite_steps_test/01: MissingCompileTimeError
redirecting_factory_malbounded_test/01: MissingCompileTimeError
@@ -1059,13 +1055,6 @@ no_such_method_mock_test: RuntimeError
null_no_such_method_test: CompileTimeError
number_identity2_test: RuntimeError
numbers_test: RuntimeError, OK # non JS number semantics
override_inheritance_field_test/04: CompileTimeError
override_inheritance_field_test/06: CompileTimeError
override_inheritance_field_test/26: CompileTimeError
override_inheritance_field_test/29: CompileTimeError
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
parser_quirks_test: CompileTimeError
redirecting_factory_default_values_test/01: MissingCompileTimeError
redirecting_factory_default_values_test/02: MissingCompileTimeError
tests/language_2/language_2_dartdevc.status
+1 -16
View File
@@ -128,14 +128,8 @@ multiline_newline_test/03r: RuntimeError
multiline_newline_test/none: RuntimeError
multiple_interface_inheritance_test: CompileTimeError # Issue 30552
nested_generic_closure_test: CompileTimeError
override_inheritance_field_test/04: CompileTimeError
override_inheritance_field_test/06: CompileTimeError
override_inheritance_field_test/26: CompileTimeError
override_inheritance_field_test/29: CompileTimeError
override_field_test/02: CompileTimeError
override_inheritance_field_test/42: CompileTimeError
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
part_of_multiple_libs_test/01: MissingCompileTimeError
part_refers_to_core_library_test/01: Crash
prefix_shadow_test/01: MissingCompileTimeError # Issue 33005
@@ -460,14 +454,6 @@ named_constructor_test/01: MissingCompileTimeError
named_parameters_default_eq_test/02: MissingCompileTimeError
no_such_method_mock_test: RuntimeError # Issue 31426 - Kernel does not introduce nSM for implemented fields.
null_no_such_method_test: CompileTimeError # Issue 31533
override_field_test/02: MissingCompileTimeError
override_inheritance_field_test/04: CompileTimeError # Issue 31616
override_inheritance_field_test/06: CompileTimeError # Issue 31616
override_inheritance_field_test/26: CompileTimeError # Issue 31616
override_inheritance_field_test/29: CompileTimeError # Issue 31616
override_inheritance_generic_test/02: CompileTimeError # Issue 31616
override_inheritance_method_test/28: CompileTimeError # Issue 31616
override_inheritance_method_test/29: CompileTimeError # Issue 31616
redirecting_factory_default_values_test/01: MissingCompileTimeError
redirecting_factory_default_values_test/02: MissingCompileTimeError
redirecting_factory_infinite_steps_test/01: MissingCompileTimeError
@@ -629,7 +615,6 @@ null_test/mirrors: RuntimeError # Uses mirrors.; ReferenceError: GenericOfT is n
number_identity2_test: RuntimeError # Issue 29920; Expect.isTrue(false) fails.
number_identity_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351
numbers_test: RuntimeError # Issue 29920; Expect.equals(expected: <false>, actual: <true>) fails.
override_field_test/03: MissingCompileTimeError
parser_quirks_test: CompileTimeError
regress_16640_test: RuntimeError # Issue 29920; Uncaught Error: type arguments should not be null: E => {
regress_22443_test: RuntimeError # Uncaught Expect.isTrue(false) fails.
tests/language_2/language_2_kernel.status
-23
View File
@@ -324,8 +324,6 @@ mixin_type_parameters_errors_test/03: MissingCompileTimeError
mixin_type_parameters_errors_test/04: MissingCompileTimeError
named_constructor_test/01: MissingCompileTimeError
named_parameters_default_eq_test/02: MissingCompileTimeError # Fasta bug: Default values are not allowed on redirecting factory constructors.
override_field_test/02: MissingCompileTimeError
override_field_test/03: MissingCompileTimeError
partial_tearoff_instantiation_test/05: MissingCompileTimeError
partial_tearoff_instantiation_test/06: MissingCompileTimeError
partial_tearoff_instantiation_test/07: MissingCompileTimeError
@@ -863,13 +861,6 @@ null_no_such_method_test: CompileTimeError # Issue 31533
null_test/mirrors: Skip # Uses mirrors.
null_test/none: SkipByDesign
overridden_no_such_method_test: SkipByDesign
override_inheritance_field_test/04: CompileTimeError # Issue 31616
override_inheritance_field_test/06: CompileTimeError # Issue 31616
override_inheritance_field_test/26: CompileTimeError # Issue 31616
override_inheritance_field_test/29: CompileTimeError # Issue 31616
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
parser_quirks_test: CompileTimeError # Issue 31533
redirecting_factory_infinite_steps_test/01: MissingCompileTimeError
redirecting_factory_malbounded_test/01: MissingCompileTimeError
@@ -1043,13 +1034,6 @@ multiline_newline_test/05r: MissingCompileTimeError
multiline_newline_test/06: MissingCompileTimeError
multiline_newline_test/06r: MissingCompileTimeError
null_no_such_method_test: CompileTimeError
override_inheritance_field_test/04: CompileTimeError
override_inheritance_field_test/06: CompileTimeError
override_inheritance_field_test/26: CompileTimeError
override_inheritance_field_test/29: CompileTimeError
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
parser_quirks_test: CompileTimeError
regress_23408_test: CompileTimeError
regress_29025_test: CompileTimeError
@@ -1492,13 +1476,6 @@ no_main_test/01: Skip
no_main_test/01: DartkCrash
no_such_method_mock_test: RuntimeError # Issue 31426
null_no_such_method_test: CompileTimeError # Issue 31533
override_inheritance_field_test/04: CompileTimeError # Issue 31616
override_inheritance_field_test/06: CompileTimeError # Issue 31616
override_inheritance_field_test/26: CompileTimeError # Issue 31616
override_inheritance_field_test/29: CompileTimeError # Issue 31616
override_inheritance_generic_test/02: CompileTimeError
override_inheritance_method_test/28: CompileTimeError
override_inheritance_method_test/29: CompileTimeError
parser_quirks_test: CompileTimeError # Issue 31533
redirecting_factory_infinite_steps_test/01: MissingCompileTimeError
redirecting_factory_malbounded_test/01: MissingCompileTimeError
tests/language_2/override_field_test.dart
+2 -2
View File
@@ -10,8 +10,8 @@ class A {
class B extends A {
static int instanceFieldInA; // //# 01: compile-time error
int staticFieldInA; // //# 02: compile-time error
static int staticFieldInA; // //# 03: compile-time error
int staticFieldInA; // //# 02: ok
static int staticFieldInA; // //# 03: ok
}
main() {
tests/language_2/override_inheritance_field_test.dart
+4 -4
View File
@@ -8,9 +8,9 @@ class A {
get getter1 => null; //# 01: ok
num get getter2 => null; //# 02: ok
num get getter3 => null; //# 03: ok
int get getter4 => null; //# 04: ok
int get getter4 => null; //# 04: compile-time error
int get getter5 => null; //# 05: compile-time error
int get getter6 => null; //# 06: ok
int get getter6 => null; //# 06: compile-time error
int get getter7 => null; //# 07: compile-time error
int get getter8 => null; //# 08: compile-time error
@@ -19,10 +19,10 @@ class A {
set setter3(_) => null; //# 23: ok
set setter4(_) => null; //# 24: ok
set setter5(num _) => null; //# 25: ok
set setter6(num _) => null; //# 26: ok
set setter6(num _) => null; //# 26: compile-time error
set setter7(int _) => null; //# 27: ok
set setter8(int _) => null; //# 28: compile-time error
set setter9(int _) => null; //# 29: ok
set setter9(int _) => null; //# 29: compile-time error
set setter10(int _) => null; //# 30: compile-time error
set setter11(int _) => null; //# 31: compile-time error
tests/language_2/override_inheritance_generic_test.dart
+1 -1
View File
@@ -4,7 +4,7 @@
class A<T> {
method1(T t) => null; //# 01: ok
method2(T t) => null; //# 02: ok
method2(T t) => null; //# 02: compile-time error
method4(T t) => null; //# 04: compile-time error
method5(T t) => null; //# 05: ok
method7(T t) => null; //# 07: compile-time error
tests/language_2/override_inheritance_method_test.dart
+18 -2
View File
@@ -32,14 +32,26 @@ class A {
method25() => null; //# 25: ok
void method26() {} //# 26: ok
int method27() => null; //# 27: compile-time error
method28(int a) => null; //# 28: ok
method29(int a) => null; //# 29: ok
method28(int a) => null; //# 28: compile-time error
method29(int a) => null; //# 29: compile-time error
method30(int a) => null; //# 30: compile-time error
method34(int a) => null; //# 34: ok
method35(int a) => null; //# 35: ok
method36(int a) => null; //# 36: compile-time error
method37(num a) => null; //# 37: ok
method38(covariant num a) => null; //# 38: ok
method39(num a) => null; //# 39: compile-time error
}
class B extends A {
method28(num a) => null; //# 28: continued
method29(a) => null; //# 29: continued
method34(num a) => null; //# 34: continued
method35(dynamic a) => null; //# 35: continued
method36(dynamic a) => null; //# 36: continued
method37(covariant dynamic a) => null; //# 37: continued
method38(dynamic a) => null; //# 38: continued
method39(covariant dynamic a) => null; //# 39: continued
}
abstract class I {
@@ -87,6 +99,10 @@ class Class extends B implements I, J {
method28(double a) => null; //# 28: continued
method29(String a) => null; //# 29: continued
method30(String a) => null; //# 30: continued
method36(int a) => null; //# 36: continued
method37(int a) => null; //# 37: continued
method38(int a) => null; //# 38: continued
method39(String a) => null; //# 39: continued
}
class SubClass extends Class {