Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
57 lines
1.2 KiB
C
57 lines
1.2 KiB
C
//
|
|
// Copyleft F.Chaxel 2017
|
|
//
|
|
|
|
#include "esp_log.h"
|
|
#include "esp_wifi.h"
|
|
|
|
#include "lwip/sockets.h"
|
|
#include "lwip/netdb.h"
|
|
|
|
#include "bacnet/datalink/bip.h"
|
|
|
|
long bip_get_addr_by_name(const char *host_name)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
void bip_set_interface(const char *ifname)
|
|
{
|
|
}
|
|
|
|
void bip_cleanup(void)
|
|
{
|
|
close(bip_socket());
|
|
bip_set_socket(-1);
|
|
}
|
|
|
|
bool bip_init(char *ifname)
|
|
{
|
|
tcpip_adapter_ip_info_t ip_info = { 0 };
|
|
|
|
int value = 1;
|
|
|
|
tcpip_adapter_get_ip_info(TCPIP_ADAPTER_IF_STA, &ip_info);
|
|
|
|
bip_set_interface(ifname);
|
|
bip_set_port(0xBAC0U);
|
|
bip_set_addr(ip_info.ip.addr);
|
|
bip_set_broadcast_addr(
|
|
(ip_info.ip.addr & ip_info.netmask.addr) | (~ip_info.netmask.addr));
|
|
|
|
int sock = socket(PF_INET, SOCK_DGRAM, IPPROTO_IP);
|
|
struct sockaddr_in saddr = { 0 };
|
|
|
|
saddr.sin_family = PF_INET;
|
|
saddr.sin_port = htons(0xBAC0U);
|
|
saddr.sin_addr.s_addr = htonl(INADDR_ANY);
|
|
bind(sock, (struct sockaddr *)&saddr, sizeof(struct sockaddr_in));
|
|
|
|
setsockopt(sock, SOL_SOCKET, SO_BROADCAST, (char *)&value, sizeof(value));
|
|
setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, (char *)&value, sizeof(value));
|
|
|
|
bip_set_socket(sock);
|
|
|
|
return true;
|
|
}
|