Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
81 lines
2.0 KiB
C
81 lines
2.0 KiB
C
/*
|
|
* Copyright (c) 2020 Legrand North America, LLC.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
/* @file
|
|
* @brief test BACnet integer encode/decode APIs
|
|
*/
|
|
|
|
#include <zephyr/ztest.h>
|
|
#include <bacnet/ihave.h>
|
|
|
|
/**
|
|
* @addtogroup bacnet_tests
|
|
* @{
|
|
*/
|
|
|
|
/**
|
|
* @brief Test
|
|
*/
|
|
static void testIHaveData(const BACNET_I_HAVE_DATA *data)
|
|
{
|
|
uint8_t apdu[480] = { 0 };
|
|
int len = 0;
|
|
int apdu_len = 0;
|
|
BACNET_I_HAVE_DATA test_data;
|
|
|
|
len = ihave_encode_apdu(&apdu[0], data);
|
|
zassert_not_equal(len, 0, NULL);
|
|
apdu_len = len;
|
|
|
|
len = ihave_decode_apdu(&apdu[0], apdu_len, &test_data);
|
|
zassert_not_equal(len, -1, NULL);
|
|
zassert_equal(test_data.device_id.type, data->device_id.type, NULL);
|
|
zassert_equal(test_data.device_id.instance, data->device_id.instance, NULL);
|
|
zassert_equal(test_data.object_id.type, data->object_id.type, NULL);
|
|
zassert_equal(test_data.object_id.instance, data->object_id.instance, NULL);
|
|
zassert_true(
|
|
characterstring_same(&test_data.object_name, &data->object_name), NULL);
|
|
}
|
|
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST(ihave_tests, testIHave)
|
|
#else
|
|
static void testIHave(void)
|
|
#endif
|
|
{
|
|
BACNET_I_HAVE_DATA data;
|
|
|
|
characterstring_init_ansi(&data.object_name, "Patricia - my love!");
|
|
data.device_id.type = OBJECT_DEVICE;
|
|
for (data.device_id.instance = 1;
|
|
data.device_id.instance <= BACNET_MAX_INSTANCE;
|
|
data.device_id.instance <<= 1) {
|
|
for (data.object_id.type = OBJECT_ANALOG_INPUT;
|
|
data.object_id.type < MAX_BACNET_OBJECT_TYPE;
|
|
data.object_id.type++) {
|
|
for (data.object_id.instance = 1;
|
|
data.object_id.instance <= BACNET_MAX_INSTANCE;
|
|
data.object_id.instance <<= 1) {
|
|
testIHaveData(&data);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
/**
|
|
* @}
|
|
*/
|
|
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST_SUITE(ihave_tests, NULL, NULL, NULL, NULL, NULL);
|
|
#else
|
|
void test_main(void)
|
|
{
|
|
ztest_test_suite(ihave_tests, ztest_unit_test(testIHave));
|
|
|
|
ztest_run_test_suite(ihave_tests);
|
|
}
|
|
#endif
|