a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
239 lines
6.9 KiB
C
239 lines
6.9 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2007 Steve Karg <skarg@users.sourceforge.net>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
*********************************************************************/
|
|
|
|
/* The module handles sending data out the RS-485 port */
|
|
/* and handles receiving data from the RS-485 port. */
|
|
/* Customize this file for your specific hardware */
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
|
|
/* This file has been customized for use with ATMEGA168 */
|
|
#include "hardware.h"
|
|
#include "rs485.h"
|
|
#include "timer.h"
|
|
|
|
/* baud rate */
|
|
static uint32_t RS485_Baud = 9600;
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Initializes the RS485 hardware and variables, and starts in
|
|
* receive mode.
|
|
* RETURN: none
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
void RS485_Initialize(void)
|
|
{
|
|
/* enable Transmit and Receive */
|
|
UCSR0B = _BV(TXEN0) | _BV(RXEN0);
|
|
|
|
/* Set USART Control and Status Register n C */
|
|
/* Asynchronous USART 8-bit data, No parity, 1 stop */
|
|
/* Set USART Mode Select: UMSELn1 UMSELn0 = 00 for Asynchronous USART */
|
|
/* Set Parity Mode: UPMn1 UPMn0 = 00 for Parity Disabled */
|
|
/* Set Stop Bit Select: USBSn = 0 for 1 stop bit */
|
|
/* Set Character Size: UCSZn2 UCSZn1 UCSZn0 = 011 for 8-bit */
|
|
/* Clock Polarity: UCPOLn = 0 when asynchronous mode is used. */
|
|
UCSR0C = _BV(UCSZ01) | _BV(UCSZ00);
|
|
/* Clear Power Reduction USART0 */
|
|
BIT_CLEAR(PRR, PRUSART0);
|
|
/* Use port PD2 for RTS - enable and disable of Transceiver Tx/Rx */
|
|
/* Set port bit as Output - initially receiving */
|
|
BIT_CLEAR(PORTD, PD2);
|
|
BIT_SET(DDRD, DDD2);
|
|
|
|
return;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Returns the baud rate that we are currently running at
|
|
* RETURN: none
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
uint32_t RS485_Get_Baud_Rate(void)
|
|
{
|
|
return RS485_Baud;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Sets the baud rate for the chip USART
|
|
* RETURN: true if valid baud rate
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
bool RS485_Set_Baud_Rate(uint32_t baud)
|
|
{
|
|
bool valid = true;
|
|
|
|
switch (baud) {
|
|
case 9600:
|
|
case 19200:
|
|
case 38400:
|
|
case 57600:
|
|
case 76800:
|
|
case 115200:
|
|
RS485_Baud = baud;
|
|
/* 2x speed mode */
|
|
BIT_SET(UCSR0A, U2X0);
|
|
/* configure baud rate */
|
|
UBRR0 = (F_CPU / (8UL * RS485_Baud)) - 1;
|
|
/* FIXME: store the baud rate */
|
|
break;
|
|
default:
|
|
valid = false;
|
|
break;
|
|
}
|
|
|
|
return valid;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Enable or disable the transmitter
|
|
* RETURN: none
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
void RS485_Transmitter_Enable(bool enable)
|
|
{
|
|
if (enable) {
|
|
BIT_SET(PORTD, PD2);
|
|
} else {
|
|
BIT_CLEAR(PORTD, PD2);
|
|
}
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Waits on the SilenceTimer for 40 bits.
|
|
* RETURN: none
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
void RS485_Turnaround_Delay(void)
|
|
{
|
|
uint8_t nbytes = 4;
|
|
|
|
RS485_Transmitter_Enable(false);
|
|
while (nbytes) {
|
|
while (!BIT_CHECK(UCSR0A, UDRE0)) {
|
|
/* do nothing - wait until Tx buffer is empty */
|
|
}
|
|
/* Send the data byte */
|
|
UDR0 = 0xff;
|
|
nbytes--;
|
|
}
|
|
/* was the frame sent? */
|
|
while (!BIT_CHECK(UCSR0A, TXC0)) {
|
|
/* do nothing - wait until the entire frame in the
|
|
Transmit Shift Register has been shifted out */
|
|
}
|
|
/* Clear the Transmit Complete flag by writing a one to it. */
|
|
BIT_SET(UCSR0A, TXC0);
|
|
}
|
|
|
|
/**
|
|
* @brief Send some data and wait until it is sent
|
|
* @param buffer - data to send
|
|
* @param nbytes - number of bytes of data
|
|
*/
|
|
void RS485_Send_Data(const uint8_t *buffer,
|
|
uint16_t nbytes)
|
|
{
|
|
while (nbytes) {
|
|
while (!BIT_CHECK(UCSR0A, UDRE0)) {
|
|
/* do nothing - wait until Tx buffer is empty */
|
|
}
|
|
/* Send the data byte */
|
|
UDR0 = *buffer;
|
|
buffer++;
|
|
nbytes--;
|
|
}
|
|
/* was the frame sent? */
|
|
while (!BIT_CHECK(UCSR0A, TXC0)) {
|
|
/* do nothing - wait until the entire frame in the
|
|
Transmit Shift Register has been shifted out */
|
|
}
|
|
/* Clear the Transmit Complete flag by writing a one to it. */
|
|
BIT_SET(UCSR0A, TXC0);
|
|
/* per MSTP spec, sort of */
|
|
Timer_Silence_Reset();
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Return true if a framing or overrun error is present
|
|
* RETURN: true if error
|
|
* ALGORITHM: autobaud - if there are a lot of errors, switch baud rate
|
|
* NOTES: Clears any error flags.
|
|
*****************************************************************************/
|
|
bool RS485_ReceiveError(void)
|
|
{
|
|
bool ReceiveError = false;
|
|
volatile uint8_t dummy_data;
|
|
|
|
/* check for framing error */
|
|
#if 0
|
|
if (BIT_CHECK(UCSR0A, FE0)) {
|
|
/* FIXME: how do I clear the error flags? */
|
|
BITMASK_CLEAR(UCSR0A, (_BV(FE0) | _BV(DOR0) | _BV(UPE0)));
|
|
ReceiveError = true;
|
|
}
|
|
#endif
|
|
/* check for overrun error */
|
|
if (BIT_CHECK(UCSR0A, DOR0)) {
|
|
/* flush the receive buffer */
|
|
do {
|
|
dummy_data = UDR0;
|
|
} while (BIT_CHECK(UCSR0A, RXC0));
|
|
ReceiveError = true;
|
|
}
|
|
(void)dummy_data;
|
|
|
|
return ReceiveError;
|
|
}
|
|
|
|
/****************************************************************************
|
|
* DESCRIPTION: Return true if data is available
|
|
* RETURN: true if data is available, with the data in the parameter set
|
|
* ALGORITHM: none
|
|
* NOTES: none
|
|
*****************************************************************************/
|
|
bool RS485_DataAvailable(uint8_t *data)
|
|
{
|
|
bool DataAvailable = false;
|
|
|
|
/* check for data */
|
|
if (BIT_CHECK(UCSR0A, RXC0)) {
|
|
*data = UDR0;
|
|
DataAvailable = true;
|
|
}
|
|
|
|
return DataAvailable;
|
|
}
|
|
|
|
#ifdef TEST_RS485
|
|
int main(void)
|
|
{
|
|
unsigned i = 0;
|
|
uint8_t DataRegister;
|
|
|
|
RS485_Set_Baud_Rate(38400);
|
|
RS485_Initialize();
|
|
/* receive task */
|
|
for (;;) {
|
|
if (RS485_ReceiveError()) {
|
|
fprintf(stderr, "ERROR ");
|
|
} else if (RS485_DataAvailable(&DataRegister)) {
|
|
fprintf(stderr, "%02X ", DataRegister);
|
|
}
|
|
}
|
|
}
|
|
#endif /* TEST_RS485 */
|