Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
62 lines
1.4 KiB
C
62 lines
1.4 KiB
C
/*
|
|
* Copyright (c) 2020 Legrand North America, LLC.
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
/* @file
|
|
* @brief test BACnet integer encode/decode APIs
|
|
*/
|
|
|
|
#include <zephyr/ztest.h>
|
|
#include <bacnet/basic/sys/filename.h>
|
|
|
|
/**
|
|
* @addtogroup bacnet_tests
|
|
* @{
|
|
*/
|
|
|
|
/**
|
|
* @brief Test
|
|
*/
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST(filename_tests, testFilename)
|
|
#else
|
|
static void testFilename(void)
|
|
#endif
|
|
{
|
|
const char *data1 = "c:\\Joshua\\run";
|
|
const char *data2 = "/home/Anna/run";
|
|
const char *data3 = "c:\\Program Files\\Christopher\\run.exe";
|
|
const char *data4 = "//Mary/data/run";
|
|
const char *data5 = "bin\\run";
|
|
const char *filename = NULL;
|
|
|
|
filename = filename_remove_path(data1);
|
|
zassert_equal(strcmp("run", filename), 0, NULL);
|
|
filename = filename_remove_path(data2);
|
|
zassert_equal(strcmp("run", filename), 0, NULL);
|
|
filename = filename_remove_path(data3);
|
|
zassert_equal(strcmp("run.exe", filename), 0, NULL);
|
|
filename = filename_remove_path(data4);
|
|
zassert_equal(strcmp("run", filename), 0, NULL);
|
|
filename = filename_remove_path(data5);
|
|
zassert_equal(strcmp("run", filename), 0, NULL);
|
|
|
|
return;
|
|
}
|
|
/**
|
|
* @}
|
|
*/
|
|
|
|
#if defined(CONFIG_ZTEST_NEW_API)
|
|
ZTEST_SUITE(filename_tests, NULL, NULL, NULL, NULL, NULL);
|
|
#else
|
|
void test_main(void)
|
|
{
|
|
ztest_test_suite(filename_tests, ztest_unit_test(testFilename));
|
|
|
|
ztest_run_test_suite(filename_tests);
|
|
}
|
|
#endif
|