Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
141 lines
3.7 KiB
C
141 lines
3.7 KiB
C
/**
|
|
* @file
|
|
* @brief BACnet BACnetAuthenticationFactorFormat codecs
|
|
* @author Nikola Jelic <nikola.jelic@euroicc.com>
|
|
* @date 2015
|
|
* @copyright SPDX-License-Identifier: MIT
|
|
*/
|
|
#include <stdint.h>
|
|
#include "bacnet/bacdcode.h"
|
|
#include "bacnet/authentication_factor_format.h"
|
|
|
|
int bacapp_encode_authentication_factor_format(
|
|
uint8_t *apdu, const BACNET_AUTHENTICATION_FACTOR_FORMAT *aff)
|
|
{
|
|
int len;
|
|
int apdu_len = 0;
|
|
|
|
len = encode_context_enumerated(&apdu[apdu_len], 0, aff->format_type);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else {
|
|
apdu_len += len;
|
|
}
|
|
|
|
if (aff->format_type == AUTHENTICATION_FACTOR_CUSTOM) {
|
|
len = encode_context_unsigned(&apdu[apdu_len], 1, aff->vendor_id);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else {
|
|
apdu_len += len;
|
|
}
|
|
|
|
len = encode_context_unsigned(&apdu[apdu_len], 2, aff->vendor_format);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else {
|
|
apdu_len += len;
|
|
}
|
|
}
|
|
return apdu_len;
|
|
}
|
|
|
|
int bacapp_encode_context_authentication_factor_format(
|
|
uint8_t *apdu, uint8_t tag, const BACNET_AUTHENTICATION_FACTOR_FORMAT *aff)
|
|
{
|
|
int len;
|
|
int apdu_len = 0;
|
|
|
|
len = encode_opening_tag(&apdu[apdu_len], tag);
|
|
apdu_len += len;
|
|
|
|
len = bacapp_encode_authentication_factor_format(&apdu[apdu_len], aff);
|
|
apdu_len += len;
|
|
|
|
len = encode_closing_tag(&apdu[apdu_len], tag);
|
|
apdu_len += len;
|
|
|
|
return apdu_len;
|
|
}
|
|
|
|
int bacapp_decode_authentication_factor_format(
|
|
const uint8_t *apdu, BACNET_AUTHENTICATION_FACTOR_FORMAT *aff)
|
|
{
|
|
int len;
|
|
int apdu_len = 0;
|
|
uint32_t format_type = aff->format_type;
|
|
BACNET_UNSIGNED_INTEGER unsigned_value = 0;
|
|
|
|
if (decode_is_context_tag(&apdu[apdu_len], 0)) {
|
|
len = decode_context_enumerated(&apdu[apdu_len], 0, &format_type);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else if (format_type < AUTHENTICATION_FACTOR_MAX) {
|
|
apdu_len += len;
|
|
aff->format_type = (BACNET_AUTHENTICATION_FACTOR_TYPE)format_type;
|
|
} else {
|
|
/* FIXME: Maybe this should return BACNET_STATUS_REJECT */
|
|
return -1;
|
|
}
|
|
} else {
|
|
return -1;
|
|
}
|
|
|
|
if (decode_is_context_tag(&apdu[apdu_len], 1)) {
|
|
len = decode_context_unsigned(&apdu[apdu_len], 1, &unsigned_value);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else {
|
|
aff->vendor_id = unsigned_value;
|
|
apdu_len += len;
|
|
}
|
|
if ((aff->format_type != AUTHENTICATION_FACTOR_CUSTOM) &&
|
|
(aff->vendor_id != 0)) {
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
if (decode_is_context_tag(&apdu[apdu_len], 2)) {
|
|
len = decode_context_unsigned(&apdu[apdu_len], 2, &unsigned_value);
|
|
if (len < 0) {
|
|
return -1;
|
|
} else {
|
|
aff->vendor_format = unsigned_value;
|
|
apdu_len += len;
|
|
}
|
|
if ((aff->format_type != AUTHENTICATION_FACTOR_CUSTOM) &&
|
|
(aff->vendor_format != 0)) {
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
return apdu_len;
|
|
}
|
|
|
|
int bacapp_decode_context_authentication_factor_format(
|
|
const uint8_t *apdu, uint8_t tag, BACNET_AUTHENTICATION_FACTOR_FORMAT *aff)
|
|
{
|
|
int len = 0;
|
|
int section_length;
|
|
|
|
if (decode_is_opening_tag_number(&apdu[len], tag)) {
|
|
len++;
|
|
section_length =
|
|
bacapp_decode_authentication_factor_format(&apdu[len], aff);
|
|
|
|
if (section_length == -1) {
|
|
len = -1;
|
|
} else {
|
|
len += section_length;
|
|
if (decode_is_closing_tag_number(&apdu[len], tag)) {
|
|
len++;
|
|
} else {
|
|
len = -1;
|
|
}
|
|
}
|
|
} else {
|
|
len = -1;
|
|
}
|
|
return len;
|
|
}
|