Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
49 lines
1.0 KiB
C
49 lines
1.0 KiB
C
/**
|
|
* @file
|
|
* @brief API for I-Have service encode and decode
|
|
* @author Steve Karg <skarg@users.sourceforge.net>
|
|
* @date 2012
|
|
* @copyright SPDX-License-Identifier: MIT
|
|
*/
|
|
#ifndef BACNET_I_HAVE_H
|
|
#define BACNET_I_HAVE_H
|
|
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
/* BACnet Stack defines - first */
|
|
#include "bacnet/bacdef.h"
|
|
/* BACnet Stack API */
|
|
#include "bacnet/bacstr.h"
|
|
|
|
typedef struct BACnet_I_Have_Data {
|
|
BACNET_OBJECT_ID device_id;
|
|
BACNET_OBJECT_ID object_id;
|
|
BACNET_CHARACTER_STRING object_name;
|
|
} BACNET_I_HAVE_DATA;
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif /* __cplusplus */
|
|
|
|
BACNET_STACK_EXPORT
|
|
int ihave_encode_apdu(
|
|
uint8_t * apdu,
|
|
const BACNET_I_HAVE_DATA * data);
|
|
|
|
BACNET_STACK_EXPORT
|
|
int ihave_decode_service_request(
|
|
const uint8_t * apdu,
|
|
unsigned apdu_len,
|
|
BACNET_I_HAVE_DATA * data);
|
|
|
|
BACNET_STACK_EXPORT
|
|
int ihave_decode_apdu(
|
|
const uint8_t * apdu,
|
|
unsigned apdu_len,
|
|
BACNET_I_HAVE_DATA * data);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif /* __cplusplus */
|
|
#endif
|