Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
178 lines
4.7 KiB
C
178 lines
4.7 KiB
C
/**
|
|
* @file
|
|
* @author Steve Karg
|
|
* @date 2005
|
|
* @brief API for a basic BACnet File Object implementation.
|
|
* @copyright SPDX-License-Identifier: MIT
|
|
*/
|
|
#ifndef BACNET_BASIC_OBJECT_FILE_H
|
|
#define BACNET_BASIC_OBJECT_FILE_H
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
/* BACnet Stack defines - first */
|
|
#include "bacnet/bacdef.h"
|
|
/* BACnet Stack API */
|
|
#include "bacnet/bacint.h"
|
|
#include "bacnet/datetime.h"
|
|
#include "bacnet/apdu.h"
|
|
#include "bacnet/arf.h"
|
|
#include "bacnet/awf.h"
|
|
#include "bacnet/rp.h"
|
|
#include "bacnet/wp.h"
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif /* __cplusplus */
|
|
|
|
BACNET_STACK_EXPORT
|
|
void BACfile_Property_Lists(
|
|
const int **pRequired,
|
|
const int **pOptional,
|
|
const int **pProprietary);
|
|
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_object_name(
|
|
uint32_t object_instance,
|
|
BACNET_CHARACTER_STRING * object_name);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_object_name_set(
|
|
uint32_t object_instance,
|
|
char *new_name);
|
|
BACNET_STACK_EXPORT
|
|
const char * bacfile_name_ansi(
|
|
uint32_t object_instance);
|
|
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_valid_instance(
|
|
uint32_t object_instance);
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_count(
|
|
void);
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_index_to_instance(
|
|
unsigned find_index);
|
|
BACNET_STACK_EXPORT
|
|
unsigned bacfile_instance_to_index(
|
|
uint32_t instance);
|
|
|
|
BACNET_STACK_EXPORT
|
|
const char * bacfile_file_type(
|
|
uint32_t object_instance);
|
|
BACNET_STACK_EXPORT
|
|
void bacfile_file_type_set(
|
|
uint32_t object_instance,
|
|
const char *mime_type);
|
|
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_archive(
|
|
uint32_t instance);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_archive_set(
|
|
uint32_t instance, bool status);
|
|
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_only(
|
|
uint32_t instance);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_only_set(
|
|
uint32_t object_instance,
|
|
bool read_only);
|
|
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_file_access_stream(
|
|
uint32_t object_instance);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_file_access_stream_set(
|
|
uint32_t object_instance,
|
|
bool access);
|
|
|
|
BACNET_STACK_EXPORT
|
|
BACNET_UNSIGNED_INTEGER bacfile_file_size(
|
|
uint32_t instance);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_file_size_set(
|
|
uint32_t object_instance,
|
|
BACNET_UNSIGNED_INTEGER file_size);
|
|
|
|
/* this is one way to match up the invoke ID with */
|
|
/* the file ID from the AtomicReadFile request. */
|
|
/* Another way would be to store the */
|
|
/* invokeID and file instance in a list or table */
|
|
/* when the request was sent */
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_instance_from_tsm(
|
|
uint8_t invokeID);
|
|
|
|
/* handler ACK helper */
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_stream_data(
|
|
BACNET_ATOMIC_READ_FILE_DATA * data);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_ack_stream_data(
|
|
uint32_t instance,
|
|
const BACNET_ATOMIC_READ_FILE_DATA * data);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_write_stream_data(
|
|
BACNET_ATOMIC_WRITE_FILE_DATA * data);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_record_data(
|
|
BACNET_ATOMIC_READ_FILE_DATA * data);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_read_ack_record_data(
|
|
uint32_t instance,
|
|
const BACNET_ATOMIC_READ_FILE_DATA * data);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_write_record_data(
|
|
const BACNET_ATOMIC_WRITE_FILE_DATA * data);
|
|
|
|
/* handling for read property service */
|
|
BACNET_STACK_EXPORT
|
|
int bacfile_read_property(
|
|
BACNET_READ_PROPERTY_DATA * rpdata);
|
|
|
|
/* handling for write property service */
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_write_property(
|
|
BACNET_WRITE_PROPERTY_DATA * wp_data);
|
|
|
|
BACNET_STACK_EXPORT
|
|
const char *bacfile_pathname(
|
|
uint32_t instance);
|
|
BACNET_STACK_EXPORT
|
|
void bacfile_pathname_set(
|
|
uint32_t instance,
|
|
const char *pathname);
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_pathname_instance(
|
|
const char *pathname);
|
|
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_read(
|
|
uint32_t object_instance,
|
|
uint8_t *buffer,
|
|
uint32_t buffer_size);
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_write(
|
|
uint32_t object_instance,
|
|
const uint8_t *buffer,
|
|
uint32_t buffer_size);
|
|
|
|
BACNET_STACK_EXPORT
|
|
uint32_t bacfile_create(
|
|
uint32_t object_instance);
|
|
BACNET_STACK_EXPORT
|
|
bool bacfile_delete(
|
|
uint32_t object_instance);
|
|
BACNET_STACK_EXPORT
|
|
void bacfile_cleanup(
|
|
void);
|
|
BACNET_STACK_EXPORT
|
|
void bacfile_init(
|
|
void);
|
|
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif /* __cplusplus */
|
|
#endif
|