Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
This port was done with the STM32 ARM Cortex-M3 STM32F103RGT6 on a STM32 Discovery Kit using the STM32 CMSIS library and drivers and IAR EWARM 6.10 compiler. The CMSIS library was 21MiB compressed, so I didn't include it as part of this project. The CMSIS and drivers can be found by following the 'Click here for STM32 embedded firmware' link from the resources page: http://www.st.com/stonline/stappl/resourceSelector/app?page=resourceSelector&doctype=FIRMWARE&SubClassID=1169 There will be a list of firmware resources. The library you are looking for is in the ‘ARM-based 32-bit MCU STM32F10xxx standard peripheral library’. Download the ‘ARM-based 32-bit MCU STM32F10xxx standard peripheral library’ and the CMSIS library can be found in '…\STM32F10x_StdPeriph_Lib_V3.4.0\Libraries\CMSIS\CM3'. Copy the contents of 'CMSIS' to the 'CMSIS' folder in this project. and the drivers library can be found in '…\STM32F10x_StdPeriph_Lib_V3.4.0\Libraries\STM32F10x_StdPeriph_Driver'. Copy the contents of 'STM32F10x_StdPeriph_Driver' to the 'drivers' folder in this project. The hardware interface only uses the USART and a peripheral pin (RTS) for the MS/TP RS-485 interface, and the System Clock for the millisecond timer. It was created for the STM32 Design Challenge on March 20, 2011, by Steve Karg. Although the design didn't win any awards, it was one of the six finalists and was on display at the STM booth at the 2010 Embedded Systems Conference West. http://www.stm32challenge.com/