Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
59 lines
1.4 KiB
C
59 lines
1.4 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2004 Steve Karg
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later WITH GCC-exception-2.0
|
|
*
|
|
*********************************************************************/
|
|
#ifndef RS485_H
|
|
#define RS485_H
|
|
|
|
#include <stdint.h>
|
|
#include "bacnet/datalink/mstp.h"
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif /* __cplusplus */
|
|
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Set_Interface(
|
|
char *ifname);
|
|
BACNET_STACK_EXPORT
|
|
const char *RS485_Interface(
|
|
void);
|
|
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Initialize(
|
|
void);
|
|
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Send_Frame(
|
|
struct mstp_port_struct_t *mstp_port, /* port specific data */
|
|
const uint8_t * buffer, /* frame to send (up to 501 bytes of data) */
|
|
uint16_t nbytes); /* number of bytes of data (up to 501) */
|
|
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Check_UART_Data(
|
|
struct mstp_port_struct_t *mstp_port); /* port specific data */
|
|
BACNET_STACK_EXPORT
|
|
uint32_t RS485_Get_Port_Baud_Rate(
|
|
struct mstp_port_struct_t *mstp_port);
|
|
BACNET_STACK_EXPORT
|
|
uint32_t RS485_Get_Baud_Rate(
|
|
void);
|
|
BACNET_STACK_EXPORT
|
|
bool RS485_Set_Baud_Rate(
|
|
uint32_t baud);
|
|
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Cleanup(
|
|
void);
|
|
BACNET_STACK_EXPORT
|
|
void RS485_Print_Ports(
|
|
void);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif /* __cplusplus */
|
|
#endif
|