Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
108 lines
3.0 KiB
C
108 lines
3.0 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2005 Steve Karg <skarg@users.sourceforge.net>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
*********************************************************************/
|
|
|
|
#ifndef BACPORT_H
|
|
#define BACPORT_H
|
|
|
|
/* common unix sockets headers needed */
|
|
#include <sys/types.h> /* basic system data types */
|
|
#include <sys/time.h> /* timeval{} for select() */
|
|
#include <time.h> /* timespec{} for pselect() */
|
|
#include <netinet/in.h> /* sockaddr_in{} and other Internet defns */
|
|
#include <arpa/inet.h> /* inet(3) functions */
|
|
#include <fcntl.h> /* for nonblocking */
|
|
#include <netdb.h>
|
|
#include <errno.h>
|
|
#include <signal.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/stat.h> /* for S_xxx file mode constants */
|
|
#include <sys/uio.h> /* for iovec{} and readv/writev */
|
|
#include <unistd.h>
|
|
#include <sys/wait.h>
|
|
#include <sys/un.h> /* for Unix domain sockets */
|
|
|
|
#ifdef HAVE_SYS_SELECT_H
|
|
#include <sys/select.h> /* for convenience */
|
|
#endif
|
|
|
|
#ifdef HAVE_POLL_H
|
|
#include <poll.h> /* for convenience */
|
|
#endif
|
|
|
|
#ifdef HAVE_STRINGS_H
|
|
#include <strings.h> /* for convenience */
|
|
#endif
|
|
|
|
/* Three headers are normally needed for socket/file ioctl's:
|
|
* <sys/ioctl.h>, <sys/filio.h>, and <sys/sockio.h>.
|
|
*/
|
|
#ifdef HAVE_SYS_IOCTL_H
|
|
#include <sys/ioctl.h>
|
|
#endif
|
|
#ifdef HAVE_SYS_FILIO_H
|
|
#include <sys/filio.h>
|
|
#endif
|
|
#ifdef HAVE_SYS_SOCKIO_H
|
|
#include <sys/sockio.h>
|
|
#endif
|
|
|
|
#include <pthread.h>
|
|
#include <semaphore.h>
|
|
|
|
#define ENUMS
|
|
#include <sys/socket.h>
|
|
#ifndef __CYGWIN__
|
|
#include <net/route.h>
|
|
#endif
|
|
#include <net/if.h>
|
|
#ifndef __CYGWIN__
|
|
#include <net/if_arp.h>
|
|
#endif
|
|
#include <features.h> /* for the glibc version number */
|
|
#if __GLIBC__ >= 2 && __GLIBC_MINOR >= 1
|
|
#include <netpacket/packet.h>
|
|
#include <net/ethernet.h> /* the L2 protocols */
|
|
#else
|
|
#include <asm/types.h>
|
|
#ifndef __CYGWIN__
|
|
#include <linux/if_packet.h>
|
|
#include <linux/if_arcnet.h>
|
|
#include <linux/if_ether.h>
|
|
#endif
|
|
#endif
|
|
#include <netinet/in.h>
|
|
#include <arpa/inet.h>
|
|
#include <sys/un.h>
|
|
#include <sys/ioctl.h>
|
|
#include <netdb.h>
|
|
#include "bacnet/basic/sys/bacnet_stack_exports.h"
|
|
|
|
#define BACNET_OBJECT_TABLE(table_name, _type, _init, _count, \
|
|
_index_to_instance, _valid_instance, _object_name, \
|
|
_read_property, _write_property, _RPM_list, \
|
|
_RR_info, _iterator, _value_list, _COV, \
|
|
_COV_clear, _intrinsic_reporting) \
|
|
static_assert(false, "Unsupported BACNET_OBJECT_TABLE for this platform")
|
|
|
|
/** @file linux/bacport.h Includes Linux network headers. */
|
|
|
|
/* Local helper functions for this port */
|
|
BACNET_STACK_EXPORT
|
|
extern int bip_get_local_netmask(
|
|
struct in_addr *netmask);
|
|
|
|
BACNET_STACK_EXPORT
|
|
extern int bip_get_local_address_ioctl(
|
|
const char *ifname,
|
|
struct in_addr *addr,
|
|
int request);
|
|
|
|
#endif
|