Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
74 lines
2.3 KiB
C
74 lines
2.3 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2005 Steve Karg <skarg@users.sourceforge.net>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
*********************************************************************/
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
#include "bacnet/config.h"
|
|
#include "bacnet/basic/tsm/tsm.h"
|
|
#include "bacnet/bacdef.h"
|
|
#include "bacnet/bacdcode.h"
|
|
#include "bacnet/whois.h"
|
|
#include "bacnet/iam.h"
|
|
#include "bacnet/basic/object/device.h"
|
|
#include "bacnet/basic/services.h"
|
|
#include "bacnet/basic/tsm/tsm.h"
|
|
|
|
bool Send_I_Am_Flag = true;
|
|
|
|
void sendIamUnicast(uint8_t *buffer, BACNET_ADDRESS *src)
|
|
{
|
|
BACNET_ADDRESS dest;
|
|
int pdu_len = 0;
|
|
BACNET_NPDU_DATA npdu_data;
|
|
|
|
/* encode the data */
|
|
int npdu_len = 0;
|
|
int apdu_len = 0;
|
|
BACNET_ADDRESS my_address;
|
|
/* The destination will be the same as the src, so copy it over. */
|
|
memcpy(&dest, src, sizeof(BACNET_ADDRESS));
|
|
/* dest->net = 0; - no, must direct back to src->net to meet BTL tests */
|
|
|
|
datalink_get_my_address(&my_address);
|
|
/* encode the NPDU portion of the packet */
|
|
npdu_encode_npdu_data(&npdu_data, false, MESSAGE_PRIORITY_NORMAL);
|
|
npdu_len = npdu_encode_pdu(&buffer[0], &dest, &my_address, &npdu_data);
|
|
/* encode the APDU portion of the packet */
|
|
apdu_len =
|
|
iam_encode_apdu(&buffer[npdu_len], Device_Object_Instance_Number(),
|
|
MAX_APDU, SEGMENTATION_NONE, Device_Vendor_Identifier());
|
|
/* send data */
|
|
pdu_len = npdu_len + apdu_len;
|
|
int bytes = datalink_send_pdu(&dest, &npdu_data, &buffer[0], pdu_len);
|
|
}
|
|
|
|
void handler_who_is(
|
|
uint8_t *service_request, uint16_t service_len, BACNET_ADDRESS *src)
|
|
{
|
|
int len = 0;
|
|
int32_t low_limit = 0;
|
|
int32_t high_limit = 0;
|
|
int32_t target_device;
|
|
|
|
len = whois_decode_service_request(
|
|
service_request, service_len, &low_limit, &high_limit);
|
|
if (len == 0) {
|
|
sendIamUnicast(&Handler_Transmit_Buffer[0], src);
|
|
} else if (len != -1) {
|
|
/* is my device id within the limits? */
|
|
target_device = Device_Object_Instance_Number();
|
|
if ((target_device >= low_limit) && (target_device <= high_limit)) {
|
|
sendIamUnicast(&Handler_Transmit_Buffer[0], src);
|
|
}
|
|
}
|
|
|
|
return;
|
|
}
|