Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
62 lines
1.3 KiB
C
62 lines
1.3 KiB
C
/**
|
|
* @file
|
|
* @author Andriy Sukhynyuk, Vasyl Tkhir, Andriy Ivasiv
|
|
* @date 2012
|
|
* @brief Datalink IP module
|
|
*
|
|
* @section LICENSE
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
#ifndef UDPMODULE_H
|
|
#define UDPMODULE_H
|
|
|
|
#include <stdint.h>
|
|
#include <stdbool.h>
|
|
#include "bacport.h"
|
|
#include "portthread.h"
|
|
#include "bacnet/datalink/bip.h"
|
|
|
|
#define MAX_BIP_APDU 1476
|
|
#define MAX_BIP_PDU (MAX_NPDU + MAX_BIP_APDU)
|
|
#define MAX_BIP_MPDU (BIP_HEADER_MAX + MAX_BIP_PDU)
|
|
/* Yes, we know this is longer than an Ethernet Frame,
|
|
a UDP payload and an IPv6 packet.
|
|
Grandfathered in from BACnet Ethernet days,
|
|
and we can rely on the lower layers of the
|
|
Ethernet stack to fragment/reassemble the BACnet MPDUs */
|
|
|
|
typedef struct ip_data {
|
|
int socket;
|
|
uint16_t port;
|
|
struct in_addr local_addr;
|
|
struct in_addr broadcast_addr;
|
|
uint8_t *buff;
|
|
uint16_t max_buff;
|
|
} IP_DATA;
|
|
|
|
|
|
void *dl_ip_thread(
|
|
void *pArgs);
|
|
|
|
bool dl_ip_init(
|
|
ROUTER_PORT * port,
|
|
IP_DATA * data);
|
|
|
|
int dl_ip_send(
|
|
IP_DATA * data,
|
|
const BACNET_ADDRESS * dest,
|
|
const uint8_t * pdu,
|
|
unsigned pdu_len);
|
|
|
|
int dl_ip_recv(
|
|
IP_DATA * data,
|
|
MSG_DATA ** msg, /* on recieve fill up message */
|
|
BACNET_ADDRESS * src,
|
|
unsigned timeout);
|
|
|
|
void dl_ip_cleanup(
|
|
IP_DATA * data);
|
|
|
|
#endif /* end of UDPMODULE_H */
|