Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
BACnet Stack - SourceForge.net Build for MPLAB IDE These are some settings that are important when building the BACnet Stack using MPLAB IDE and MCC18 Compiler, 1. Add the files to the project that you need: abort.c, apdu.c, bacapp.c, bacdcode.c, bacerror.c, bacstr.c, crc.c, datetime.c, dcc.c, iam.c, npdu.c, rd.c, reject.c, rp.c, whois.c, wp.c From ports/picxx: isr.c, main.c, rs485.c, mstp.c, dlmstp.c From demo/object/: device.c or dev_tiny.c objects as needed: ai.c, ao.c, etc. From demo/handler/: txbuf.c, h_dcc.c, h_rd.c, h_rp.c or h_rp_tiny.c Additional handlers as needed: h_wp.c 2. Project->Options->Project General Tab: Include Path: C:\code\bacnet-stack\;C:\code\bacnet-stack\demo\handler\;C:\code\bacnet-stack\demo\object\;C:\code\bacnet-stack\ports\pic18f6720\ MPLAB C18 Tab: Memory Model: Code: Large Code Model Data: Large Data Model Stack: Multi-bank Model MPLAB C18 Tab: General: Macro Definitions: PRINT_ENABLED=0 BACDL_MSTP=1 TSM_ENABLED=0 3. The linker script must reserve some extra stack space. //DATABANK NAME=gpr12 START=0xC00 END=0xCFF //DATABANK NAME=gpr13 START=0xD00 END=0xDFF DATABANK NAME=stackreg START=0xC00 END=0xDFF PROTECTED //STACK SIZE=0x100 RAM=gpr13 STACK SIZE=0x200 RAM=stackreg