Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
BACnet MS/TP on Atmel XMEGA-A3BU XPLAINED evaluation board. An RS-485 add-on board (daughterboard, shield) was designed to handle the RS-485 interface and some LEDs. See rs485-shield/ folder for EAGLE CAD design files. Use the Configuration "Debug-XPLAINED" and not in "Debug" or "Release". "CONF_BOARD_ENABLE_RS485_XPLAINED" is defined and used in led.c, rs485.c, and main.c for specific board I/O. When it is not defined, the I/O is either removed (i.e. led.c, main.c) or altered (rs485.c). There are other defines in the "Debug-XPLAINED" Configuration which include other parts of the XPLAINED platform code. For your own board, you could just change rs485.c, main.c, and led.c to use the I/O that you want to use, and not worry about the "CONF_BOARD_ENABLE_RS485_XPLAINED". Or you can leave the "CONF_BOARD_ENABLE_RS485_XPLAINED" in the files so that you can always test on the XPLAINED platform with Debug-XPLAINED, and use "Debug" or "Release" for your project.