Files
bacnet_stack/.github/workflows/lint.yml
T
Kari Argillander 0177c59f4a Use pre-commit and editorconfig (#753)
* Add editorconfig and pre-commit config

Editorconfig is widly used and supported file. It says basic things how
files should be formatted.

pre-commit is tool which can automatically check some basic checks like
code formatting everytime someone makes commit. This can also be used in
CI to run these things. Then it is very easy to do same things locally
as in CI. This also makes easy to select clang-format version so
everyone is using same one.

* clang-format: Ignore folders where are external code

We should not format external code. Add clang-format files to exclude
those. We should move external code always to example external/ folder
so we can exclude those more easily.

* clang-format: Remove custom zephyr/.clang-gormat

This clang-format file where introduces before our root clang-format. It
does not make sense anymore as we have root clang-format. Removing this
will unifie formatting in whole repo.

* clang-format: Add couple new rules

Add couple new formatting rules.

Always align const to left side. We did have only one place where it was
right side so this make sense as it is already rule for us.

I choose also insertbraces becuase when I run this I notice that we have
lot of multiline code without braces. So very error prone places. This
will take error possibility away. Repo also always use braces even with
single line statments so this does not matter much.

* ci: Add pre-commit validation

Validate pre-commit in CI.

* format: Convert spaces to tabs in Makefiles

Makefile normally use tabs. We enforce that with editorconfig. Fix
couple places where spaces where still in use.

---------

Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
2024-08-28 17:04:00 -05:00

93 lines
2.1 KiB
YAML

name: Quality
on:
push:
branches:
- master
pull_request:
branches:
- '*'
jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- uses: pre-commit/action@v3.0.1
scan-build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create LLVM clang-tools scan-build Workspace
run: |
sudo apt-get update -qq
sudo apt-get install -qq clang-tools
- name: Static Defect Analysis using scan-build
run: |
make clean
make scan-build
splint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create SPLint Workspace
run: |
sudo apt-get update --quiet --assume-yes
sudo apt-get install --quiet --assume-yes splint
- name: Static Defect Analysis using SPLint
run: make splint
cppcheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create CPPcheck Workspace
run: |
sudo apt-get update -qq
sudo apt-get install -qq cppcheck
- name: Static Defect Analysis using CPPcheck
run: |
cppcheck --version
make clean
make cppcheck
flawfinder:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create Flawfinder Workspace
run: |
sudo apt-get update -qq
sudo apt-get install -qq flawfinder
- name: Static Defect Analysis using flawfinder
run: |
flawfinder --version
make clean
make flawfinder
codespell:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create codespell Workspace
run: |
sudo apt-get update -qq
sudo apt-get install -qq codespell
- name: Static Spelling Analysis using codespell
run: make spell
unittest:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Create Build Environment
run: |
sudo apt-get update -qq
sudo apt-get install -qq lcov
- name: Run Unit Test with Code Coverage
run: make test