Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
77 lines
2.1 KiB
C
77 lines
2.1 KiB
C
/**************************************************************************
|
|
*
|
|
* Copyright (C) 2005 Steve Karg <skarg@users.sourceforge.net>
|
|
*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
*********************************************************************/
|
|
#ifndef AI_H
|
|
#define AI_H
|
|
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include "bacnet/bacdef.h"
|
|
#include "bacnet/rp.h"
|
|
#include "bacnet/wp.h"
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif /* __cplusplus */
|
|
void Analog_Input_Property_Lists(
|
|
const int **pRequired,
|
|
const int **pOptional,
|
|
const int **pProprietary);
|
|
|
|
bool Analog_Input_Valid_Instance(
|
|
uint32_t object_instance);
|
|
unsigned Analog_Input_Count(
|
|
void);
|
|
uint32_t Analog_Input_Index_To_Instance(
|
|
unsigned index);
|
|
unsigned Analog_Input_Instance_To_Index(
|
|
uint32_t instance);
|
|
bool Analog_Input_Object_Instance_Add(
|
|
uint32_t instance);
|
|
|
|
char *Analog_Input_Name(
|
|
uint32_t object_instance);
|
|
bool Analog_Input_Name_Set(
|
|
uint32_t object_instance,
|
|
const char *new_name);
|
|
|
|
const char *Analog_Input_Description(
|
|
uint32_t instance);
|
|
bool Analog_Input_Description_Set(
|
|
uint32_t instance,
|
|
const char *new_name);
|
|
|
|
bool Analog_Input_Units_Set(
|
|
uint32_t instance,
|
|
uint16_t units);
|
|
uint16_t Analog_Input_Units(
|
|
uint32_t instance);
|
|
|
|
int Analog_Input_Read_Property(
|
|
BACNET_READ_PROPERTY_DATA * rpdata);
|
|
bool Analog_Input_Write_Property(
|
|
BACNET_WRITE_PROPERTY_DATA * wp_data);
|
|
|
|
float Analog_Input_Present_Value(
|
|
uint32_t object_instance);
|
|
void Analog_Input_Present_Value_Set(
|
|
uint32_t object_instance,
|
|
float value);
|
|
|
|
void Analog_Input_Init(
|
|
void);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif /* __cplusplus */
|
|
#define ANALOG_INPUT_OBJ_FUNCTIONS \
|
|
OBJECT_ANALOG_INPUT, Analog_Input_Init, Analog_Input_Count, \
|
|
Analog_Input_Index_To_Instance, Analog_Input_Valid_Instance, \
|
|
Analog_Input_Name, Analog_Input_Read_Property, NULL, \
|
|
Analog_Input_Property_Lists, NULL, NULL
|
|
#endif
|