Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
Win32 ports for BACnet
This directory contains a demo program that compiles with a Win32 compiler. It was tested with the free MinGW32 MSYS2 GCC compiler and the (free) Microsoft Visual Studio Community Edition
Building with Makefile under MinGW32
Note: Building for 64-bit with MinGW64 requires extra runtimes, whereas building for 32-bit as Win32 doesn't require any other files for the EXE to work in any version of Windows.
-
MSYS2 installation is (from powershell):
c:> winget install --id=MSYS2.MSYS2 -e
-
Start MSYS shell, and install MinGW32.
$ pacman -Syu mingw-w64-i686-toolchain
-
Edit ~/.bashrc file and add:
alias make=mingw32-make.exe
-
Exit MSYS.
-
Start MSYS profile for MinGW32.
-
Verify MSYS profile:
$ uname
MINGW32_NT-10.0-19045
-
Verify GCC is targeting i686:
$ gcc -dumpmachine
i686-w64-mingw32
-
Verify make is built for Windows32:
make --version
Built for Windows32
Building and running with Microsoft Visual Studio
- Obtain the (free) Microsoft Visual Studio Community Edition, or use your professional version. Currently tested to MSVC 2022
- Open solution file ports/win32/Microsoft Visual Studio/bacnet-stack.sln
- Set startup project to be the desired application project, e.g. "server"
- In the active project properties, debugging, set command line to desired DeviceID
- In active project properties, debugging, set environment variables as appropriate, e.g. BACNET_IFACE=10.59.2.1 BACNET_IP_PORT=53004
- Compile & run
- Questions? edward@bac-test.com