Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
Port of BACnet/IP to LwIP 2.x
This LwIP BACnet/IP port uses a Makefile designed to be used from the continuous integration pipeline. The container is configured with Ubuntu Linux and uses APT to install liblwip-dev library and header files. This build method ensures that the code is valid for the particular LwIP library that is released with Ubuntu.
Integration Hints
Developer must set the IP address, netmask, and UDP port into the BACnet/IP module.
Integration used a main loop bare metal design, shown here as an example.
int main(void)
{
static bool valid_ip_address = false;
static bool bacnet_ip_initialized = false;
bacnet_init();
LwIP_Init();
/* Infinite loop */
for (;;) {
/* Periodic tasks */
LwIP_Periodic_Handler();
/* Run when there is a valid IP address */
if (netif.ip_addr.addr != 0) {
if (!valid_ip_address) {
valid_ip_address = true;
bip_set_addr(netif.ip_addr.addr);
bip_set_broadcast_addr(
(netif.ip_addr.addr & netif.netmask.addr) |
(~netif.netmask.addr));
} else {
if (bacnet_ip_initialized) {
bacnet_task();
} else {
bip_init(NULL);
bacnet_ip_initialized = true;
}
}
} else {
valid_ip_address = false;
}
}
}