Kari Argillander
a2f1d6959d
* Make most of the functions const correct
Used clang-tidy and sonarlint to help find places where const could
pretty easily applied. Also lot of hand work.
This commit does not yet touch handlers and typedefs of those.
* Fix Arduino uno handler_who_is() has extra parenthesis
For some reason there is extra parenthesis. Remove it this is more
likely buildable.
* Bugfix/bacapp: Fix uninitilized array_index
We have changed bacapp_snprintf_value() to be const correct. After that
we got
```
/home/runner/work/bacnet-stack/bacnet-stack/src/bacnet/bacapp.c:3183:27: warning: 4th function call argument is an uninitialized value [core.CallAndMessage]
ret_val = bacapp_snprintf_weeklyschedule(
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
```
So analyzer could now spot that we do not actually initilize array_index
at all. Fix this by setting array_index to zero. Note that I actually do
not know if zeroing is right thing to do here. I choose zero as if this
has worked before it is most likely that it will work with zero value.
* cmake: Add and ignore Wwrite-strings compiler option
Wwrite-strings helps find places where const correctness is broken.
Example it will warn about these
```C
void func1(char* str);
func("test") /* "test" is const so we should not pass it to func1().
char* func2()
{
return "test"; /* func2() should return const char*.
}
```
We still need to ignore it as not all are fixed but let's add it already
so we remember that it should be opened at some point.
---------
Co-authored-by: Kari Argillander <kari.argillander@fidelix.com>
BACnet Simple Router Demo ========================= The Simple Router demo connects one BACnet/IP and one BACnet MS/TP network. The router demo also includes a BBMD so that Foreign Device Registration can be used to tunnel local command line demos to BACnet/IP and BACnet MS/TP networks. Configuration ============= It uses environment variables to configure the MS/TP COM port and BACnet/IP address on Windows: set BACNET_IFACE=192.168.0.1 set BACNET_MSTP_IFACE=COM1 set BACNET_MSTP_BAUD=38400 set BACNET_MSTP_MAC=99 It uses environment variables to configure the MS/TP COM port and BACnet/IP address on Linux: export BACNET_IFACE=eth0 export BACNET_MSTP_IFACE=/dev/ttyUSB0 export BACNET_MSTP_BAUD=38400 export BACNET_MSTP_MAC=99 Also uses these configurations, but defaults to these values if not set: set BACNET_MAX_INFO_FRAMES=128 set BACNET_MAX_MASTER=127 set BACNET_IP_PORT=47808 set BACNET_IP_NET=1 set BACNET_MSTP_NET=2 Note: NET number must be unique and 1..65534 (never 0 or 65535) Example Usage ============= Build the demo applications for BACnet/IP: $ make Build the simple router demo: $ make router-mstp Configure the router demo: $ ./bin/router-mstp.sh enp0s3 /dev/ttyUSB0 Run the router demo: $ ./bin/router-mstp In another terminal, configure client apps for Foreign Device Registration: $ ./bin/bvlc.sh 192.168.0.1 $ ./bin/bacwi -1 $ ./bin/bacepics 123